Misc/Cleanup

* moving commonly used strings to defines
 * moving commonly reused/similar page generation functions to the parent
 * generally using consistent return types, more type hints and less strings
 * prevent browser context menu when right clicking on UI elements with their own context menus
 * fixed menu path for icons
This commit is contained in:
Sarjuuk
2020-05-23 13:01:10 +02:00
parent b044488308
commit 6cabfd3864
38 changed files with 418 additions and 618 deletions

View File

@@ -282,7 +282,7 @@ class AjaxComment extends AjaxHandler
protected function handleCommentOutOfDate() : string
{
$this->contentType = 'text/plain';
$this->contentType = MIME_TYPE_TEXT;
if (!$this->_post['id'])
{
@@ -320,7 +320,7 @@ class AjaxComment extends AjaxHandler
protected function handleReplyAdd() : string
{
$this->contentType = 'text/plain';
$this->contentType = MIME_TYPE_TEXT;
if (!User::canComment())
return Lang::main('cannotComment');
@@ -343,7 +343,7 @@ class AjaxComment extends AjaxHandler
protected function handleReplyEdit() : string
{
$this->contentType = 'text/plain';
$this->contentType = MIME_TYPE_TEXT;
if (!User::canComment())
return Lang::main('cannotComment');