BaseTypes:

- rewrote BaseType::iterate() to be a generator and yield references (requires php 5.5)
- reduced usage of bandaid BaseType::reset()
- removed Util::getIdFieldName() which was even more of a bandaid
- discovered DBSimple::selectPage() and consequently removed $matchQuery as they are now obsoloete

Util:
- added trainerTemplate lists for future use with trainers and trained spells

misc. forgotten and/or broken stuff here and there

setup/tools/sql/_item.php

@@ -29,7 +29,7 @@ class ItemSetup extends ItemList
 
     public function writeStatsTable()
     {
-        while ($this->iterate())
+        foreach ($this->iterate() as $__)
         {
             $this->extendJsonStats();
             $updateFields = [];

setup/tools/sql/_itemset.php

@@ -288,7 +288,7 @@ foreach ($locales as $loc)
 
     $name[$loc] = '"'.Util::sqlEscape(Util::localizedString($set, 'name')).'"';
 
-    while ($bonusSpells->iterate())
+    foreach ($bonusSpells->iterate() as $__)
         @$descText[$loc] .= $bonusSpells->parseText()[0]."\n";
 
     $descText[$loc] = '"'.Util::sqlEscape($descText[$loc]).'"';

setup/tools/sql/skills.sql

@@ -56,7 +56,6 @@ UPDATE aowow_skillLine sl, dbc.spell s, dbc.skillLineAbility sla SET sl.spellIco
 UPDATE aowow_skillLine sl, dbc.spellIcon si SET sl.iconString = SUBSTRING_INDEX(si.string, '\\', -1) WHERE sl.spellIconId = si.id;
 UPDATE aowow_skillLine SET iconString = 'inv_misc_questionmark' WHERE spellIconId = 0;
 
-
 -- categorization
 UPDATE aowow_skillLine SET typeCat = -5 WHERE id = 777 OR (categoryId = 9 AND id NOT IN (356, 129, 185, 142, 155));
 UPDATE aowow_skillLine SET typeCat = -4 WHERE categoryId = 9 AND name_loc0 LIKE '%racial%';