yolinlin/aowow
1
0
Fork 0
mirror of https://github.com/Sarjuuk/aowow.git synced 2025-11-29 15:58:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

DB/SqlModes

Browse Source 
* only update sql_mode if strictly necessary
* keep other modes set in my.cfg / my.ini
This commit is contained in:
Sarjuuk
2024-04-18 19:14:47 +02:00
committed by GitHub
parent 67d4f12cfe
commit d084e6072b
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
includes/database.class.php
View File

@@ -13,7 +13,6 @@ class DB
{ {
private static $interfaceCache = []; private static $interfaceCache = [];
private static $optionsCache = []; private static $optionsCache = [];
private static $connectionCache = [];
private static $logs = []; private static $logs = [];
@@ -39,14 +38,15 @@ class DB
$interface->setIdentPrefix($options['prefix']); $interface->setIdentPrefix($options['prefix']);
// disable STRICT_TRANS_TABLES and STRICT_ALL_TABLES off. It prevents usage of implicit default values. // disable STRICT_TRANS_TABLES and STRICT_ALL_TABLES off. It prevents usage of implicit default values.
if ($idx == DB_AOWOW)
$interface->query("SET SESSION sql_mode = 'NO_ENGINE_SUBSTITUTION'");
// disable ONLY_FULL_GROUP_BY (Allows for non-aggregated selects in a group-by query) // disable ONLY_FULL_GROUP_BY (Allows for non-aggregated selects in a group-by query)
else $extraModes = ['STRICT_TRANS_TABLES', 'STRICT_ALL_TABLES', 'ONLY_FULL_GROUP_BY'];
$interface->query("SET SESSION sql_mode = ''"); $oldModes = explode(',', $interface->selectCell('SELECT @@sql_mode'));
$newModes = array_diff($oldModes, $extraModes);
if ($oldModes != $newModes)
$interface->query("SET SESSION sql_mode = ?", implode(',', $newModes));
self::$interfaceCache[$idx] = &$interface; self::$interfaceCache[$idx] = &$interface;
self::$connectionCache[$idx] = true;
} }
public static function test(array $options, ?string &$err = '') : bool public static function test(array $options, ?string &$err = '') : bool
@@ -122,7 +122,7 @@ class DB
public static function isConnected($idx) public static function isConnected($idx)
{ {
return isset(self::$connectionCache[$idx]); return isset(self::$interfaceCache[$idx]);
} }
public static function isConnectable($idx) public static function isConnectable($idx)