PHP/Compat

* fixed misc issues Intellisense was nice enough to highlight.
 * mostly deprecated usage of uninitialized parameters
 * class GenericPage still needs a long, hard look and a refactor

includes/types/arenateam.class.php

@@ -122,6 +122,7 @@ class RemoteArenaTeamList extends ArenaTeamList
                 );
 
     private     $members   = [];
+    private     $rankOrder = [];
 
     public function __construct($conditions = [], $miscData = null)
     {

includes/types/item.class.php

@@ -22,6 +22,9 @@ class ItemList extends BaseType
     private         $vendors    = [];
     private         $jsGlobals  = [];                       // getExtendedCost creates some and has no access to template
 
+    private         $enhanceR   = [];
+    private         $relEnchant = [];
+
     protected       $queryBase  = 'SELECT i.*, i.block AS tplBlock, i.armor AS tplArmor, i.dmgMin1 AS tplDmgMin1, i.dmgMax1 AS tplDmgMax1, i.id AS ARRAY_KEY, i.id AS id FROM ?_items i';
     protected       $queryOpts  = array(                    // 3 => Type::ITEM
                         'i'   => [['is', 'src', 'ic'], 'o' => 'i.quality DESC, i.itemLevel DESC'],

includes/types/profile.class.php

@@ -509,6 +509,8 @@ class RemoteProfileList extends ProfileList
                     'at'  => [['atm'], 'j' => 'arena_team at ON atm.arenaTeamId = at.arenaTeamId', 's' => ', at.name AS arenateam, IF(at.captainGuid = c.guid, 1, 0) AS captain']
                 );
 
+    private     $rnItr     = [];                            // rename iterator [name => nCharsWithThisName]
+
     public function __construct($conditions = [], $miscData = null)
     {
         // select DB by realm