* define magic numbers from combat ratings
* move forgotten rating base values from Util to Stats
* fix localized rating strings for item and spell tooltips (expected float, got string)
* some cleanup in item/spell types to make it more clear when an internal stat is being handled, not an itemMod or combatRating
* prevent direct access to some internal files where applicable and reword error for others
* if CFG_DEBUG is set also enable debug in client javascript
* non-breaking formatting changes
* define regions and missing locales for later use
* unify stat handling. If there are discrepancies left at least they are now centralized.
- health should no longer pretend to be mana
- stats are no longer capped to 32.7k points as items can have multiple of the same stat and handily exceed smallints
* weight scale fixes:
- "repair cost" is no longer a weight scale option. Why was it one in the first place? Also it wasn't even accessible before. (that was a bug)
- "bonus armor" is now searchable and only applied to armor pieces
* removed unused parsed stats from itemsets
* relax numeric type requirements when working with filters
* restore smart type casting functionality of Util::checkNumeric when used with NUM_ANY
* enable Util::arraySumByKey to work recursively
* fix source display in listview
* only throw errors if there is actually a config to work with. (like, not when you are just setting up for the first time)
* do not use trigger_error() in CLI mode as it can cause a lockup as the error_handler tries to throw more errors.
* assign lost validator fn flag to settings
* also use validator onReset
* Conditions: loot rows initially have no 'id'
* fixed building talent string for hunter pets (different talents can occupy the same row/col spot)
* added keys loot cols on creature table
* fixed trying to show itemset type for itemsets without type
* fixed waypoint calculation when moving entity between floors
* rewritten and moved to its own class, should be easier to expand in the future
* add missing sources and types from TrinityCore
* implement conditions on Areatrigger and Loot containers
* implement reverse lookups (e.g. a spell is a conditional for something else)
* general beautification pass .. should be more legible in general
NOTE:
* texts have been changed, so the existing translation for esES ist gone
* selecting and describing condition targets is still wonky
* convert configuration from list of constants to object
* fixes config changes not applying on cli whithout closing and reopening again
* config variables are no longer embedded in localization text
* don't need to handle sql warnings in batch when the error handler doesn't use exit() any longer
* display warnings as [WARN] and use consts instead of magic numbers
* implement SpawnedByDefault from TC
* maybe fix a longstanding issue where multiple parent areas per instanced map lead to wrong spawn points
map should be can also be
36 The Deadmines The Great Sea, Unused Ironcladcove
109 The Temple of Atal'Hakkar Sunken Temple
540 The Shattered Halls Hellfire Citadel
560 Old Hillsbrad Foothills Hyjal Past
631 Icecrown Citadel The Frost Queen's Lair, Putricide's Laboratory of Alchemical Horrors and Fun, The Crimson Hall, The Frozen Throne, The Sanctum of Blood
* do not urlencode mysqli uris .. can't wait for this to cause issues again.
* input[type=number] does not allow inputing dashes to signify negative numbers. Use input[type=text] instead and cast to int afterwards.
* enable level scaling for spells with RealPointsPerLevel
* note: While BasePoint vars ($m, $M) can scale, they are often involved in formulas that would have to be recalculated in javascript. This is currently impossible. So this var is skipped for now.
* improve db error handling
* web view should always result in an user friendly error if the db connection is missing or erronous
* cli use should never fatal if the db connection is erronous. How are you going to fix it, d'uh.
* if some CLISetup script requires a db connection check it individually
* use built in function to determine if CLI can use escape codes
* define _post, _get and _cookie in all cases
* do not apply 8 regexes to a string that doesn't even contain a UI Sequence
* fixed misc issues Intellisense was nice enough to highlight.
* mostly deprecated usage of uninitialized parameters
* class GenericPage still needs a long, hard look and a refactor
* so, apparently the client allows ui escape sequences in the weirdest of places. Guess i have to follow suit.
* also, the sequences can be multiline
* also also, the file extension for icons is optional
* fixed "modefied-by" and "modifies" tab having different results
* evalueate some more spell effects
* replace magic numbers with defined strings
* get model info from some more spell auras
