Profiler/Fixup

* fix exception when manually querying for unsynced guild/arena-team
   that shares it's name with another guild/team (e.g. ìíîi is the same to SQL)
   and the target guild/team not being the first result

endpoints/arena-team/arena-team.php

@@ -58,9 +58,9 @@ class ArenateamBaseResponse extends TemplateResponse
 
         // 2) not yet synced but exists on realm (wont work if we get passed an urlized name, but there is nothing we can do about it)
         $subjects = DB::Characters($this->realmId)->select('SELECT at.`arenaTeamId` AS "realmGUID", at.`name`, at.`type` FROM arena_team at WHERE at.`name` = ?', $this->subjectName);
-        if ($subject = array_filter($subjects, fn($x) => Util::lower($x['name']) == Util::lower($this->subjectName)))
+        if ($subject = array_filter($subjects, fn($x) => Util::lower($x['name']) === Util::lower($this->subjectName)))
         {
-            $subject = $subject[0];
+            $subject = array_pop($subject);
             $subject['realm']   = $this->realmId;
             $subject['stub']    = 1;
             $subject['nameUrl'] = Profiler::urlize($subject['name']);

endpoints/go-to-comment/go-to-comment.php

@@ -21,8 +21,9 @@ class GotocommentBaseResponse extends TextResponse
             return;
         }
 
-        // type <> 0 AND typeId <> 0 AND replyTo = 0 for comments
-        $comment = DB::Aowow()->selectRow('SELECT `id`, `type`, `typeId` FROM ?_comments WHERE `replyTo` = 0 AND `id` = ?d', $this->_get['id']);
+        // the reputation-history listview only creates go-to-comment links. So either upvoting replies does not grant reputation, or.... bug.?
+
+        $comment = DB::Aowow()->selectRow('SELECT IFNULL(c2.`id`, c1.`id`) AS "id", IFNULL(c2.`type`, c1.`type`) AS "type", IFNULL(c2.`typeId`, c1.`typeId`) AS "typeId" FROM ?_comments c1 LEFT JOIN ?_comments c2 ON c1.`replyTo` = c2.`id` WHERE c1.`id` = ?d', $this->_get['id']);
         if (!$comment)
         {
             trigger_error('GotocommentBaseResponse - comment #'.$this->_get['id'].' not found', E_USER_ERROR);
@@ -36,6 +37,8 @@ class GotocommentBaseResponse extends TextResponse
         }
 
         $this->redirectTo = sprintf('?%s=%d#comments:id=%d', Type::getFileString($comment['type']), $comment['typeId'], $comment['id']);
+        if ($comment['id'] != $this->_get['id'])     // i am reply
+            $this->redirectTo .= ':reply='.$this->_get['id'];
     }
 }
 

endpoints/guild/guild.php

@@ -58,9 +58,9 @@ class GuildBaseResponse extends TemplateResponse
 
         // 2) not yet synced but exists on realm (wont work if we get passed an urlized name, but there is nothing we can do about it)
         $subjects = DB::Characters($this->realmId)->select('SELECT `guildid` AS "realmGUID", `name` FROM guild WHERE `name` = ?', $this->subjectName);
-        if ($subject = array_filter($subjects, fn($x) => Util::lower($x['name']) == Util::lower($this->subjectName)))
+        if ($subject = array_filter($subjects, fn($x) => Util::lower($x['name']) === Util::lower($this->subjectName)))
         {
-            $subject = $subject[0];
+            $subject = array_pop($subject);
             $subject['realm']   = $this->realmId;
             $subject['stub']    = 1;
             $subject['nameUrl'] = Profiler::urlize($subject['name']);