From 61fd3eebf95596897eca3fe817cef43ba4ed81f4 Mon Sep 17 00:00:00 2001 From: AG <43139552+AGandrup@users.noreply.github.com> Date: Sun, 12 Nov 2023 16:37:16 +0100 Subject: [PATCH] fix(Metric/Misc): Change default updatetime to 1s (#17627) * Update default metric interval * codestyle * ready for merge --------- Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com> --- src/common/Metric/Metric.cpp | 2 +- src/server/apps/worldserver/worldserver.conf.dist | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/common/Metric/Metric.cpp b/src/common/Metric/Metric.cpp index 908ffc676..8a2ecabd8 100644 --- a/src/common/Metric/Metric.cpp +++ b/src/common/Metric/Metric.cpp @@ -71,7 +71,7 @@ void Metric::LoadFromConfigs() { bool previousValue = _enabled; _enabled = sConfigMgr->GetOption("Metric.Enable", false); - _updateInterval = sConfigMgr->GetOption("Metric.Interval", 10); + _updateInterval = sConfigMgr->GetOption("Metric.Interval", 1); if (_updateInterval < 1) { diff --git a/src/server/apps/worldserver/worldserver.conf.dist b/src/server/apps/worldserver/worldserver.conf.dist index 95aae29dd..944ebb773 100644 --- a/src/server/apps/worldserver/worldserver.conf.dist +++ b/src/server/apps/worldserver/worldserver.conf.dist @@ -780,11 +780,13 @@ Metric.Enable = 0 # # Metric.Interval -# Description: Interval between every batch of data sent in seconds -# Default: 10 seconds +# Description: Interval between every batch of data sent in seconds. +# Longer interval means larger batch of data. If the batch +# is too big, it might get rejected. +# Default: 1 second # -Metric.Interval = 10 +Metric.Interval = 1 # # Metric.ConnectionInfo