* Added modules to dbimport so sql cab accessed by loader
* updated dbimport tools config option to enable module sql to be updated and populated
* Updated casting around GetOption and changed default to all
* initial version
* port most current checks
* allow to specify for each checks the exclude files
* Update _ci-codestyle.py
* fix trailing whitespace check and the error_handler logic
* optimize the script to parse all files only one time
* restore the error handling after that all checks are passed
* fix double blank lines at the end of the file
* improve outputs and the codestyle
* .
* update github workflow to the new script
*drop the old ci-codestyle
*move and rename the python script
* use getcwd instead abspath to define src_directory where the script is launch
* test for github workflow
* few cleanup
* fix the logic with the result output
* remove GetTypeId from the output result
* restore GetTypeId() check
* fix reviews
* remove GetTypeId check for gameobjects
*not currently fixed in the core
* fix type hint for file parameters
* remove the test file
* fix(CI/MacOS): Try to fix macOS mysql setup.
* Update ci-compile.sh
* More debug code
* Mooooore debug
* Moooooorreee
* Moooooooooooorereerererer
* m o r e debug
* more debug
* more
* More debug
* 9.0.1.reinstall??? we already had mysql?
* debug
* Debug
* Are we happy now?
* No? And what about now?!
* Adn now?
* Yes, we are happy 😎
* chore(CI): Make some changes. Less CI's maybe better...
* pendingsql
* FORK TEST - TO BE REVERTED
* changes
* test
* fix
* Revert "FORK TEST - TO BE REVERTED"
This reverts commit 875bc281c5a355cce2ddd8015484e256dbc185cf.
* rename workflow
* rename workflow
* rename workflow
* rename workflow
* I argue windows don't need dry runs
* maybe mac wants to be alive. who knows. When do we drop mac support really...?
* refactor(Docker): remove prod containers
* workflows: use buildx
* properly set tags
* comment in Dockerfile
* set docker build context
* minor CI changes
* CI: docker build args shouldnt have quotes
* CI: using matrix and caching is too much work
* CI: I hate yaml
* CI: It was a typo
* CI: extra build removed
* CI: appease the linter
* fixup! CI: appease the linter
* fixup! CI: appease the linter
* apps: docker: remove extraneous files
* remove deno as a dependency
* use the ACORE_VERSION env var
* I forgot client-data
* accidentally removed too much
* docker-cmd: extraneous parallel flag
* typo
* remove docker image prune -af
the `docker image prune` removes the containers we just build.
* fetch everything in the beginning
* refactor(DB/Misc): Improve loading time
* NOTE: Running these SQL files can take several minutes (up to 30minutes depending on your system!)
* This will improve loading time over 50%
* comment out error on editing broadcast_text tables
* Update data/sql/updates/pending_db_world/rev_1679045387127819800.sql
## Changes Proposed:
- This properly moves things from `DOCKER_ETC_FOLDER` to `confDir`
- originally broken with
888a718cf3
## Issues Addressed:
- Should hopefully close
https://github.com/azerothcore/acore-docker/issues/12
## SOURCE:
## Tests Performed:
- I'm not exactly aware of the testing procedure for this, as I don't
use acore-docker
- That said, the previous behavior has been replicated:
2420d19e54/apps/compiler/includes/functions.sh (L148-L150)
- Open to suggestions
## How to Test the Changes:
1. Open to Suggestions
## Known Issues and TODO List:
- Test properly
## How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as **[WAITING TO BE
TESTED]**.
You can help by testing PRs and writing your feedback here on the PR's
page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
**REMEMBER**: when testing a PR that changes something **generic** (i.e.
a part of code that handles more than one specific thing), the tester
should not only check that the PR does its job (e.g. fixing spell XXX)
but **especially** check that the PR does not cause any regression (i.e.
introducing new bugs).
**For example**: if a PR fixes spell X by changing a part of code that
handles spells X, Y, and Z, we should not only test X, but **we should
test Y and Z as well**.
<!-- First of all, THANK YOU for your contribution. -->
## Changes Proposed
- This fixes an issue where the .conf files aren't properly generated for the docker build
- With this issue, the dbimport service in the docker compose file would fail to start due to insufficient config.
- related to PR #14707
- create a ".user" file extension for custom configs in `env/docker/etc/`
- Layers the ".dockerdist" file and the ".user" file over the ".dist" file (in that order), and then copies the ".dist" file to the base ".conf" file
- Docker specific config changes go in the ".dockerdist" file and should still be committed to the repo
- User specific config changes go in ".user" file and should not be committed to the repo
- If the ".dist" file and the base ".conf" file are different, the ".conf" will be backed up before the ".dist" file is copied into it
## Issues Addressed:
<!-- If your fix has a relating issue, link it below -->
- There isn't a specific issue, however this was reported and discussed in discord over the course of yesterday and today
## SOURCE:
<!-- If you can, include a source that can strengthen your claim -->
## Tests Performed:
<!-- Does it build without errors? Did you test in-game? What did you test? On which OS did you test? Describe any other tests performed -->
- Executing commands to build and start the game server
- after creating an account, I can log in and play without any issues.
## How to Test the Changes:
<!-- Describe in a detailed step-by-step order how to test the changes -->
1. Execute commands
```bash
$ ./acore.sh docker clean:build && ./acore.sh docker build:nocache && ./acore.sh docker start:app
```
2. Create account and log in as normal
## Known Issues and TODO List:
<!-- Is there anything else left to do after this PR? -->
- The largest issue that comes to mind is this is a breaking change for docker users (though, so was the change that caused this)
- Docker users (and nobody else, of course) can no longer use the ".conf" for custom changes in docker setups.
- Their custom changes will have to be migrated to the ".user" file
- Since the old ".conf" file is backed up, users should have minimal trouble copying the changes in the old ".conf" file to the new ".user" file
<!-- If you intend to contribute repeatedly to our project, it is a good idea to join our discord channel. We set ranks for our contributors and give them access to special resources or knowledge: https://discord.com/invite/DasJqPba)
Do not remove the instructions below about testing, they will help users to test your PR -->
## How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as **[WAITING TO BE TESTED]**.
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
**REMEMBER**: when testing a PR that changes something **generic** (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but **especially** check that the PR does not cause any regression (i.e. introducing new bugs).
**For example**: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but **we should test Y and Z as well**.
edit: link related PR
* Remove .dist file requirement
* Remove unnecessary string cast
* Add required variables for CI build configs
* More required variables
* Add some more default variables to reduce log output
* One last default value to cut down log spam
* Rewrite conf file bash script
This should use the standard .dest file as a template
* Change dir we copy the dest files from
* actually use the correct file name
* need to use double quotes for variables
* add missing username
* set the correct datadir
* Attempt to fix dbimport
Co-authored-by: Foereaper <foereaper@elunatech.com>
