From 44f1f1f71b9d75b21dea6ca1cf87c5948e97829e Mon Sep 17 00:00:00 2001
From: kissingers <33601959+kissingers@users.noreply.github.com>
Date: Mon, 8 Sep 2025 16:11:16 +0800
Subject: [PATCH] Fix player AdvanceSkill method crash (#309)

Co-authored-by: iThorgrim <125808072+iThorgrim@users.noreply.github.com>
---
 src/LuaEngine/methods/PlayerMethods.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/LuaEngine/methods/PlayerMethods.h b/src/LuaEngine/methods/PlayerMethods.h
index fc4939b..0a68ac6 100644
--- a/src/LuaEngine/methods/PlayerMethods.h
+++ b/src/LuaEngine/methods/PlayerMethods.h
@@ -3087,12 +3087,12 @@ namespace LuaPlayer
     {
         uint32 _skillId = Eluna::CHECKVAL<uint32>(L, 2);
         uint32 _step = Eluna::CHECKVAL<uint32>(L, 3);
-        if (_skillId && _step)
+        bool success = false;
+        if (_skillId && _step && player->HasSkill(_skillId))
         {
-            if (player->HasSkill(_skillId))
-                Eluna::Push(L, player->UpdateSkill(_skillId, _step));
+            success = player->UpdateSkill(_skillId, _step);
         }
-        Eluna::Push(L, false);
+        Eluna::Push(L, success);
         return 1;
     }