From 2594208988a660a4a6d144059144dae627669f7c Mon Sep 17 00:00:00 2001 From: Jelle Meeus Date: Fri, 12 Apr 2024 01:00:01 +0200 Subject: [PATCH 1/2] fix: warning comparison of integers of different signs: 'uint32' (aka 'unsigned int') and 'int32' (aka 'int') --- src/naxx40Scripts/boss_gluth_40.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/naxx40Scripts/boss_gluth_40.cpp b/src/naxx40Scripts/boss_gluth_40.cpp index 604f5f9..d862394 100644 --- a/src/naxx40Scripts/boss_gluth_40.cpp +++ b/src/naxx40Scripts/boss_gluth_40.cpp @@ -204,7 +204,7 @@ public: { if (zombie->IsAlive()) { - int32 reduceHp = int32(zombie->GetMaxHealth() * 0.05f); + uint32 reduceHp = uint32(zombie->GetMaxHealth() * 0.05f); if (zombie->GetHealth() > reduceHp) zombie->SetHealth(reduceHp); // Reduce HP to 5% zombie->SetWalk(true); // Set to walk From 19e3835761183442ea41ac4f0be3f26ecda0e441 Mon Sep 17 00:00:00 2001 From: Jelle Meeus Date: Fri, 12 Apr 2024 01:01:09 +0200 Subject: [PATCH 2/2] fix: warning unused parameter 'go' [-Wunused-parameter] --- src/naxx40Scripts/instance_naxxramas.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/naxx40Scripts/instance_naxxramas.cpp b/src/naxx40Scripts/instance_naxxramas.cpp index e5b8659..5cfe1c7 100644 --- a/src/naxx40Scripts/instance_naxxramas.cpp +++ b/src/naxx40Scripts/instance_naxxramas.cpp @@ -1363,7 +1363,7 @@ public: return new gobject_naxx40_teleAI(object); } - bool OnGossipHello(Player* player, GameObject* go) override + bool OnGossipHello(Player* player, GameObject* /*go*/) override { if ((!sIndividualProgression->requireNaxxStrath || player->GetQuestStatus(NAXX40_ENTRANCE_FLAG) == QUEST_STATUS_REWARDED) && isAttuned(player)) {