From 649e55dd8485cbd25902647135366a529851adf2 Mon Sep 17 00:00:00 2001
From: avirar <luke.thorpe@gmail.com>
Date: Tue, 17 Dec 2024 12:35:49 +1100
Subject: [PATCH] Prevent bots attacking dummy Targets at the Argent Tournament
 Grounds

There was existing code to ignore practice targets (anything with Dummy in the name) so I've just added the names of practice targets located in the tournament grounds:

Charge Target
Melee Target
Ranged Target

I considered just using the phrase "Target", but it is too generic and there are 246 creature_template names containing Target.
---
 src/strategy/actions/ChooseTargetActions.cpp | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/strategy/actions/ChooseTargetActions.cpp b/src/strategy/actions/ChooseTargetActions.cpp
index 9d94c2cf..cc35180a 100644
--- a/src/strategy/actions/ChooseTargetActions.cpp
+++ b/src/strategy/actions/ChooseTargetActions.cpp
@@ -49,8 +49,15 @@ bool AttackAnythingAction::isUseful()
         return false;
 
     std::string const name = std::string(target->GetName());
-    if (!name.empty() && name.find("Dummy") != std::string::npos)  // Target is not a targetdummy
-        return false;
+    // Check for invalid targets: Dummy, Charge Target, Melee Target, Ranged Target
+    if (!name.empty() &&
+        (name.find("Dummy") != std::string::npos ||
+         name.find("Charge Target") != std::string::npos ||
+         name.find("Melee Target") != std::string::npos ||
+         name.find("Ranged Target") != std::string::npos))
+    {
+        return false;  // Target is one of the disallowed types
+    }
 
     // if (!ChooseRpgTargetAction::isFollowValid(bot, target))                               //Do not grind mobs far
     // away from master.