From 4661715fcae05ef22cfec78b884c111464797624 Mon Sep 17 00:00:00 2001
From: Yunfan Li <lyf_liyunfan@sina.com>
Date: Fri, 28 Jun 2024 20:16:29 +0800
Subject: [PATCH] [Optimization] Valid target check order

---
 src/strategy/values/AttackersValue.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/strategy/values/AttackersValue.cpp b/src/strategy/values/AttackersValue.cpp
index 7ae853be..527b8def 100644
--- a/src/strategy/values/AttackersValue.cpp
+++ b/src/strategy/values/AttackersValue.cpp
@@ -174,8 +174,7 @@ bool AttackersValue::IsPossibleTarget(Unit* attacker, Player* bot, float range)
 
 bool AttackersValue::IsValidTarget(Unit *attacker, Player *bot)
 {
-    return bot->IsWithinLOSInMap(attacker) &&
-        IsPossibleTarget(attacker, bot);
+    return IsPossibleTarget(attacker, bot) && bot->IsWithinLOSInMap(attacker);
         // (attacker->GetThreatMgr().getCurrentVictim() || attacker->GetGuidValue(UNIT_FIELD_TARGET) ||
         // attacker->GetGUID().IsPlayer() || attacker->GetGUID() == GET_PLAYERBOT_AI(bot)->GetAiObjectContext()->GetValue<ObjectGuid>("pull target")->Get());
 }