yolinlin/mod-playerbots
1
0
Fork 0
mirror of https://github.com/mod-playerbots/mod-playerbots synced 2025-11-29 15:58:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

FIX: part of logic in picking quest reward (#1752)

Browse Source 
* FIX: part of logic in picking reward

Avoids dereferencing begin() after confirming the set is empty.

* Update TalkToQuestGiverAction.cpp
This commit is contained in:
SaW
2025-10-21 10:36:10 +02:00
committed by GitHub
parent 7e810f8174
commit 6e1c9114df
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/strategy/actions/TalkToQuestGiverAction.cpp
View File

@@ -205,17 +205,18 @@ void TalkToQuestGiverAction::RewardMultipleItem(Quest const* quest, Object* ques
} }
else else
{ {
// Try to pick the usable item. If multiple list usable rewards. // Try to pick the usable item. If multiple, list usable rewards.
bestIds = BestRewards(quest); bestIds = BestRewards(quest);
if (!bestIds.empty())
{ if (bestIds.size() > 1)
AskToSelectReward(quest, out, true); AskToSelectReward(quest, out, true);
}
else else if (!bestIds.empty())
{ {
// Pick the first item // Pick the first item
ItemTemplate const* item = sObjectMgr->GetItemTemplate(quest->RewardChoiceItemId[*bestIds.begin()]); uint32 firstId = *bestIds.begin();
bot->RewardQuest(quest, *bestIds.begin(), questGiver, true); ItemTemplate const* item = sObjectMgr->GetItemTemplate(quest->RewardChoiceItemId[firstId]);
bot->RewardQuest(quest, firstId, questGiver, true);
out << "Rewarded " << ChatHelper::FormatItem(item); out << "Rewarded " << ChatHelper::FormatItem(item);
} }