From 92ce54a3cdebf28397b55679f6bba35da0b3c98b Mon Sep 17 00:00:00 2001 From: whipowill Date: Fri, 20 May 2022 12:41:13 -0500 Subject: [PATCH] Compile bug fixes. --- src/PlayerbotAI.cpp | 2 +- src/PlayerbotMgr.h | 2 +- src/TravelMgr.h | 10 +++---- src/TravelNode.cpp | 8 +++--- src/strategy/Action.h | 2 +- src/strategy/ItemVisitors.h | 2 +- src/strategy/Multiplier.h | 2 +- src/strategy/Strategy.cpp | 22 ++++++++-------- src/strategy/Strategy.h | 4 +-- src/strategy/Trigger.h | 4 +-- src/strategy/Value.h | 4 +-- src/strategy/actions/MailAction.h | 4 +-- src/strategy/actions/MovementActions.cpp | 2 +- src/strategy/deathknight/BloodDKStrategy.cpp | 6 ++--- src/strategy/deathknight/FrostDKStrategy.cpp | 8 +++--- .../GenericDKNonCombatStrategy.cpp | 4 +-- .../deathknight/GenericDKStrategy.cpp | 24 ++++++++--------- src/strategy/deathknight/UnholyDKStrategy.cpp | 6 ++--- src/strategy/druid/BearTankDruidStrategy.cpp | 26 +++++++++---------- src/strategy/druid/CasterDruidStrategy.cpp | 18 ++++++------- src/strategy/druid/CatDpsDruidStrategy.cpp | 22 ++++++++-------- src/strategy/druid/FeralDruidStrategy.cpp | 16 ++++++------ .../druid/GenericDruidNonCombatStrategy.cpp | 10 +++---- src/strategy/druid/GenericDruidStrategy.cpp | 18 ++++++------- src/strategy/hunter/DpsHunterStrategy.cpp | 10 +++---- .../hunter/GenericHunterNonCombatStrategy.cpp | 4 +-- src/strategy/hunter/GenericHunterStrategy.cpp | 10 +++---- src/strategy/mage/ArcaneMageStrategy.cpp | 6 ++--- .../mage/GenericMageNonCombatStrategy.cpp | 6 ++--- src/strategy/mage/GenericMageStrategy.cpp | 22 ++++++++-------- src/strategy/paladin/DpsPaladinStrategy.cpp | 8 +++--- src/strategy/paladin/TankPaladinStrategy.cpp | 2 +- src/strategy/priest/HolyPriestStrategy.cpp | 2 +- src/strategy/rogue/DpsRogueStrategy.cpp | 14 +++++----- src/strategy/shaman/CasterShamanStrategy.cpp | 2 +- src/strategy/shaman/GenericShamanStrategy.cpp | 20 +++++++------- src/strategy/shaman/HealShamanStrategy.cpp | 4 +-- src/strategy/shaman/MeleeShamanStrategy.cpp | 6 ++--- src/strategy/warlock/DpsWarlockStrategy.cpp | 2 +- .../GenericWarlockNonCombatStrategy.cpp | 10 +++---- .../warlock/GenericWarlockStrategy.cpp | 4 +-- src/strategy/warlock/TankWarlockStrategy.cpp | 6 ++--- 42 files changed, 182 insertions(+), 182 deletions(-) diff --git a/src/PlayerbotAI.cpp b/src/PlayerbotAI.cpp index 35e30bd5..a4148eb1 100644 --- a/src/PlayerbotAI.cpp +++ b/src/PlayerbotAI.cpp @@ -253,7 +253,7 @@ void PlayerbotAI::UpdateAI(uint32 elapsed, bool minimal) YieldThread(min); } -void PlayerbotAI::UpdateAIInternal([[maybe_unused]] uint32 elapsed, bool minimal) // unused param - whipowill +void PlayerbotAI::UpdateAIInternal([[maybe_unused]] uint32 elapsed, bool minimal) { if (bot->IsBeingTeleported() || !bot->IsInWorld()) return; diff --git a/src/PlayerbotMgr.h b/src/PlayerbotMgr.h index cace0fbf..27c56580 100644 --- a/src/PlayerbotMgr.h +++ b/src/PlayerbotMgr.h @@ -35,7 +35,7 @@ class PlayerbotHolder : public PlayerbotAIBase PlayerBotMap::const_iterator GetPlayerBotsBegin() const { return playerBots.begin(); } PlayerBotMap::const_iterator GetPlayerBotsEnd() const { return playerBots.end(); } - void UpdateAIInternal([[maybe_unused]] uint32 elapsed, [[maybe_unused]] bool minimal = false) override { }; // unused params - whipowill + void UpdateAIInternal([[maybe_unused]] uint32 elapsed, [[maybe_unused]] bool minimal = false) override { }; void UpdateSessions(); void HandleBotPackets(WorldSession* session); diff --git a/src/TravelMgr.h b/src/TravelMgr.h index 8d574e33..55664ba4 100644 --- a/src/TravelMgr.h +++ b/src/TravelMgr.h @@ -346,7 +346,7 @@ inline ByteBuffer& operator<<(ByteBuffer& b, WorldPosition& guidP) return b; } -inline ByteBuffer& operator>>(ByteBuffer& b, [[maybe_unused]] WorldPosition& g) // unused param - whipowill +inline ByteBuffer& operator>>(ByteBuffer& b, [[maybe_unused]] WorldPosition& g) { uint32 mapid; float coord_x; @@ -557,7 +557,7 @@ class TravelDestination } virtual Quest const* GetQuestTemplate() { return nullptr; } - virtual bool isActive([[maybe_unused]] Player* bot) { return false; } // unused param - whipowill + virtual bool isActive([[maybe_unused]] Player* bot) { return false; } bool isFull(bool ignoreFull = false); @@ -600,13 +600,13 @@ class NullTravelDestination : public TravelDestination Quest const* GetQuestTemplate() override { return nullptr; } - bool isActive([[maybe_unused]] Player* bot) override { return false; } // unused param - whipowill + bool isActive([[maybe_unused]] Player* bot) override { return false; } std::string const getName() override { return "NullTravelDestination"; } std::string const getTitle() override { return "no destination"; } - bool isIn([[maybe_unused]] WorldPosition* pos, [[maybe_unused]] float radius = 0.f) override { return true; } // unused params - whipowill - bool isOut([[maybe_unused]] WorldPosition* pos, [[maybe_unused]] float radius = 0.f) override { return false; } // unused params - whipowill + bool isIn([[maybe_unused]] WorldPosition* pos, [[maybe_unused]] float radius = 0.f) override { return true; } + bool isOut([[maybe_unused]] WorldPosition* pos, [[maybe_unused]] float radius = 0.f) override { return false; } }; //A travel target specifically related to a quest. diff --git a/src/TravelNode.cpp b/src/TravelNode.cpp index 8a799fff..ecae1930 100644 --- a/src/TravelNode.cpp +++ b/src/TravelNode.cpp @@ -579,7 +579,7 @@ bool TravelNode::isEqual(TravelNode* compareNode) return true; } -void TravelNode::print([[maybe_unused]] bool printFailed) // unused param - whipowill +void TravelNode::print([[maybe_unused]] bool printFailed) { WorldPosition* startPosition = getPosition(); @@ -901,7 +901,7 @@ float TravelNodeRoute::getTotalDistance() return totalLength; } -TravelPath TravelNodeRoute::buildPath(std::vector pathToStart, std::vector pathToEnd, [[maybe_unused]] Unit* bot) // unused param - whipowill +TravelPath TravelNodeRoute::buildPath(std::vector pathToStart, std::vector pathToEnd, [[maybe_unused]] Unit* bot) { TravelPath travelPath; @@ -1036,7 +1036,7 @@ TravelNodeMap::TravelNodeMap(TravelNodeMap* baseMap) baseMap->m_nMapMtx.unlock_shared(); } -TravelNode* TravelNodeMap::addNode(WorldPosition pos, std::string const preferedName, bool isImportant, bool checkDuplicate, [[maybe_unused]] bool transport, [[maybe_unused]] uint32 transportId) // unused params - whipowill +TravelNode* TravelNodeMap::addNode(WorldPosition pos, std::string const preferedName, bool isImportant, bool checkDuplicate, [[maybe_unused]] bool transport, [[maybe_unused]] uint32 transportId) { TravelNode* newNode; @@ -1124,7 +1124,7 @@ std::vector TravelNodeMap::getNodes(WorldPosition pos, float range) return std::move(retVec); } -TravelNode* TravelNodeMap::getNode(WorldPosition pos, [[maybe_unused]] std::vector& ppath, Unit* bot, float range) // unused param - whipowill +TravelNode* TravelNodeMap::getNode(WorldPosition pos, [[maybe_unused]] std::vector& ppath, Unit* bot, float range) { float x = pos.getX(); float y = pos.getY(); diff --git a/src/strategy/Action.h b/src/strategy/Action.h index ba9316ab..f67f9ed6 100644 --- a/src/strategy/Action.h +++ b/src/strategy/Action.h @@ -46,7 +46,7 @@ class Action : public AiNamedObject Action(PlayerbotAI* botAI, std::string const name = "action") : AiNamedObject(botAI, name), verbose(false) { } // verbose after ainamedobject - whipowill virtual ~Action(void) { } - virtual bool Execute([[maybe_unused]] Event event) { return true; } // unused param - whipowill + virtual bool Execute([[maybe_unused]] Event event) { return true; } virtual bool isPossible() { return true; } virtual bool isUseful() { return true; } virtual NextAction** getPrerequisites() { return nullptr; } diff --git a/src/strategy/ItemVisitors.h b/src/strategy/ItemVisitors.h index 137925d2..6a981aac 100644 --- a/src/strategy/ItemVisitors.h +++ b/src/strategy/ItemVisitors.h @@ -181,7 +181,7 @@ class QueryNamedItemCountVisitor : public QueryItemCountVisitor class FindNamedItemVisitor : public FindItemVisitor { public: - FindNamedItemVisitor([[maybe_unused]] Player* bot, std::string const name) : FindItemVisitor(), name(name) { } // unused param - whipowill + FindNamedItemVisitor([[maybe_unused]] Player* bot, std::string const name) : FindItemVisitor(), name(name) { } bool Accept(ItemTemplate const* proto) override { diff --git a/src/strategy/Multiplier.h b/src/strategy/Multiplier.h index 65c5bf55..7bb39c73 100644 --- a/src/strategy/Multiplier.h +++ b/src/strategy/Multiplier.h @@ -16,7 +16,7 @@ class Multiplier : public AiNamedObject Multiplier(PlayerbotAI* botAI, std::string const name) : AiNamedObject(botAI, name) {} virtual ~Multiplier() { } - virtual float GetValue([[maybe_unused]] Action* action) { return 1.0f; } // unused param - whipowill + virtual float GetValue([[maybe_unused]] Action* action) { return 1.0f; } }; #endif diff --git a/src/strategy/Strategy.cpp b/src/strategy/Strategy.cpp index 677e8d0e..201e6997 100644 --- a/src/strategy/Strategy.cpp +++ b/src/strategy/Strategy.cpp @@ -24,7 +24,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory } private: - static ActionNode* melee([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* melee([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("melee", /*P*/ nullptr, @@ -32,7 +32,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* healthstone([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* healthstone([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("healthstone", /*P*/ nullptr, @@ -40,7 +40,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* follow_master_random([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* follow_master_random([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("be near", /*P*/ nullptr, @@ -48,7 +48,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* attack_anything([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* attack_anything([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("attack anything", /*P*/ nullptr, @@ -56,7 +56,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* move_random([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* move_random([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("move random", /*P*/ nullptr, @@ -64,7 +64,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* move_to_loot([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* move_to_loot([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("move to loot", /*P*/ nullptr, @@ -72,7 +72,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* food([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* food([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("food", /*P*/ nullptr, @@ -80,7 +80,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* drink([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* drink([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("drink", /*P*/ nullptr, @@ -88,7 +88,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* mana_potion([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* mana_potion([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("mana potion", /*P*/ nullptr, @@ -96,7 +96,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* healing_potion([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* healing_potion([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("healing potion", /*P*/ nullptr, @@ -104,7 +104,7 @@ class ActionNodeFactoryInternal : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* flee([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* flee([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("flee", /*P*/ nullptr, diff --git a/src/strategy/Strategy.h b/src/strategy/Strategy.h index 278dda2d..0bfffd43 100644 --- a/src/strategy/Strategy.h +++ b/src/strategy/Strategy.h @@ -44,8 +44,8 @@ class Strategy : public PlayerbotAIAware virtual ~Strategy() { } virtual NextAction** getDefaultActions() { return nullptr; } - virtual void InitTriggers([[maybe_unused]] std::vector &triggers) { } // unused params - whipowill - virtual void InitMultipliers([[maybe_unused]] std::vector &multipliers) { } // unused params - whipowill + virtual void InitTriggers([[maybe_unused]] std::vector &triggers) { } + virtual void InitMultipliers([[maybe_unused]] std::vector &multipliers) { } virtual std::string const getName() = 0; virtual uint32 GetType() const { return STRATEGY_TYPE_GENERIC; } virtual ActionNode* GetAction(std::string const name); diff --git a/src/strategy/Trigger.h b/src/strategy/Trigger.h index a2106609..46a03843 100644 --- a/src/strategy/Trigger.h +++ b/src/strategy/Trigger.h @@ -19,8 +19,8 @@ class Trigger : public AiNamedObject virtual ~Trigger() { } virtual Event Check(); - virtual void ExternalEvent([[maybe_unused]] std::string const param, [[maybe_unused]] Player* owner = nullptr) { } // unused params - whipowill - virtual void ExternalEvent([[maybe_unused]] WorldPacket& packet, [[maybe_unused]] Player* owner = nullptr) { } // unused params - whipowill + virtual void ExternalEvent([[maybe_unused]] std::string const param, [[maybe_unused]] Player* owner = nullptr) { } + virtual void ExternalEvent([[maybe_unused]] WorldPacket& packet, [[maybe_unused]] Player* owner = nullptr) { } virtual bool IsActive() { return false; } virtual NextAction** getHandlers() { return nullptr; } void Update() { } diff --git a/src/strategy/Value.h b/src/strategy/Value.h index 60ebe666..0fc1c3c9 100644 --- a/src/strategy/Value.h +++ b/src/strategy/Value.h @@ -24,7 +24,7 @@ class UntypedValue : public AiNamedObject virtual void Reset() { } virtual std::string const Format() { return "?"; } virtual std::string const Save() { return "?"; } - virtual bool Load([[maybe_unused]] std::string const value) { return false; } // unused param - whipowill + virtual bool Load([[maybe_unused]] std::string const value) { return false; } }; template @@ -135,7 +135,7 @@ class MemoryCalculatedValue : public CalculatedValue return true; } - void Set([[maybe_unused]] T value) override // unused param - whipowill + void Set([[maybe_unused]] T value) override { CalculatedValue::Set(this->value); UpdateChange(); diff --git a/src/strategy/actions/MailAction.h b/src/strategy/actions/MailAction.h index 18311171..9bf864d9 100644 --- a/src/strategy/actions/MailAction.h +++ b/src/strategy/actions/MailAction.h @@ -15,9 +15,9 @@ struct Mail; class MailProcessor { public: - virtual bool Before([[maybe_unused]] PlayerbotAI* botAI) { return true; } // unused param - whipowill + virtual bool Before([[maybe_unused]] PlayerbotAI* botAI) { return true; } virtual bool Process(uint32 index, Mail* mail, PlayerbotAI* botAI) = 0; - virtual bool After([[maybe_unused]] PlayerbotAI* botAI) { return true; } // unused param - whipowill + virtual bool After([[maybe_unused]] PlayerbotAI* botAI) { return true; } static ObjectGuid FindMailbox(PlayerbotAI* botAI); diff --git a/src/strategy/actions/MovementActions.cpp b/src/strategy/actions/MovementActions.cpp index 6a350bf7..7b363929 100644 --- a/src/strategy/actions/MovementActions.cpp +++ b/src/strategy/actions/MovementActions.cpp @@ -1048,7 +1048,7 @@ bool MovementAction::Flee(Unit *target) } } - HostileReference* ref = target->getThreatMgr().getCurrentVictim(); + HostileReference* ref = target->GetThreatMgr().getCurrentVictim(); if (ref && ref->getTarget() == bot) // bot is target - try to flee to tank or master { if (Group* group = bot->GetGroup()) diff --git a/src/strategy/deathknight/BloodDKStrategy.cpp b/src/strategy/deathknight/BloodDKStrategy.cpp index 35e5b38a..3a4476b2 100644 --- a/src/strategy/deathknight/BloodDKStrategy.cpp +++ b/src/strategy/deathknight/BloodDKStrategy.cpp @@ -33,7 +33,7 @@ class BloodDKStrategyActionNodeFactory : public NamedObjectFactory } private: - static ActionNode* rune_strike([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* rune_strike([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("rune strike", /*P*/ NextAction::array(0, new NextAction("frost presence"), nullptr), @@ -41,7 +41,7 @@ class BloodDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* heart_strike([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* heart_strike([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("heart strike", /*P*/ NextAction::array(0, new NextAction("frost presence"), nullptr), @@ -49,7 +49,7 @@ class BloodDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* death_strike([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* death_strike([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("death strike", /*P*/ NextAction::array(0, new NextAction("frost presence"), nullptr), diff --git a/src/strategy/deathknight/FrostDKStrategy.cpp b/src/strategy/deathknight/FrostDKStrategy.cpp index 3bf14dd3..9a263f98 100644 --- a/src/strategy/deathknight/FrostDKStrategy.cpp +++ b/src/strategy/deathknight/FrostDKStrategy.cpp @@ -30,7 +30,7 @@ class FrostDKStrategyActionNodeFactory : public NamedObjectFactory } private: - static ActionNode* obliterate([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* obliterate([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("obliterate", /*P*/ NextAction::array(0, new NextAction("blood presence"), nullptr), @@ -38,7 +38,7 @@ class FrostDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* rune_strike([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* rune_strike([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("rune strike", /*P*/ NextAction::array(0, new NextAction("blood presence"), nullptr), @@ -46,7 +46,7 @@ class FrostDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* frost_strike([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* frost_strike([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("frost strike", /*P*/ NextAction::array(0, new NextAction("blood presence"), nullptr), @@ -54,7 +54,7 @@ class FrostDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* howling_blast([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* howling_blast([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("howling blast", /*P*/ NextAction::array(0, new NextAction("blood presence"), nullptr), diff --git a/src/strategy/deathknight/GenericDKNonCombatStrategy.cpp b/src/strategy/deathknight/GenericDKNonCombatStrategy.cpp index 2cfeabf5..3f2cecc2 100644 --- a/src/strategy/deathknight/GenericDKNonCombatStrategy.cpp +++ b/src/strategy/deathknight/GenericDKNonCombatStrategy.cpp @@ -15,7 +15,7 @@ class GenericDKNonCombatStrategyActionNodeFactory : public NamedObjectFactory } private: - static ActionNode* death_coil([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* death_coil([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("death coil", /*P*/ nullptr, @@ -58,7 +58,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* death_grip([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* death_grip([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("death grip", /*P*/ nullptr, @@ -66,7 +66,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* plague_strike([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* plague_strike([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("plague strike", /*P*/ nullptr, @@ -74,7 +74,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* icy_touch([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* icy_touch([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("icy touch", /*P*/ nullptr, @@ -82,7 +82,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* heart_strike([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* heart_strike([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("heart strike", /*P*/ nullptr, @@ -90,7 +90,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* pestilence([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* pestilence([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("pestilence", /*P*/ nullptr, @@ -98,7 +98,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* horn_of_winter([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* horn_of_winter([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("horn of winter", /*P*/ nullptr, @@ -106,7 +106,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* bone_shield([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* bone_shield([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("bone shield", /*P*/ nullptr, @@ -114,7 +114,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* killing_machine([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* killing_machine([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("killing machine", /*P*/ nullptr, @@ -122,7 +122,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* corpse_explosion([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* corpse_explosion([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("corpse explosion", /*P*/ nullptr, @@ -130,7 +130,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* anti_magic_zone([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* anti_magic_zone([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("anti magic zone", /*P*/ nullptr, @@ -138,7 +138,7 @@ class GenericDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* icebound_fortitude([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* icebound_fortitude([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("icebound fortitude", /*P*/ nullptr, diff --git a/src/strategy/deathknight/UnholyDKStrategy.cpp b/src/strategy/deathknight/UnholyDKStrategy.cpp index bc6f9df2..1e255b10 100644 --- a/src/strategy/deathknight/UnholyDKStrategy.cpp +++ b/src/strategy/deathknight/UnholyDKStrategy.cpp @@ -30,7 +30,7 @@ class UnholyDKStrategyActionNodeFactory : public NamedObjectFactory } private: - static ActionNode* death_strike([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* death_strike([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("death strike", /*P*/ NextAction::array(0, new NextAction("unholy pressence"), nullptr), @@ -38,7 +38,7 @@ class UnholyDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* corpse_explosion([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* corpse_explosion([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("corpse explosion", /*P*/ NextAction::array(0, new NextAction("unholy pressence"), nullptr), @@ -46,7 +46,7 @@ class UnholyDKStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* scourge_strike([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* scourge_strike([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode("scourge strike", /*P*/ NextAction::array(0, new NextAction("unholy pressence"), nullptr), diff --git a/src/strategy/druid/BearTankDruidStrategy.cpp b/src/strategy/druid/BearTankDruidStrategy.cpp index 62b115cd..80a2807b 100644 --- a/src/strategy/druid/BearTankDruidStrategy.cpp +++ b/src/strategy/druid/BearTankDruidStrategy.cpp @@ -25,7 +25,7 @@ class BearTankDruidStrategyActionNodeFactory : public NamedObjectFactory } private: - static ActionNode* viper_sting([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* viper_sting([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("viper sting", /*P*/ nullptr, @@ -26,7 +26,7 @@ class DpsHunterStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* aimed_shot([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* aimed_shot([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("aimed shot", /*P*/ nullptr, @@ -34,7 +34,7 @@ class DpsHunterStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* chimera_shot([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* chimera_shot([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("chimera shot", /*P*/ nullptr, @@ -42,7 +42,7 @@ class DpsHunterStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* explosive_shot([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* explosive_shot([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("explosive shot", /*P*/ nullptr, @@ -50,7 +50,7 @@ class DpsHunterStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* concussive_shot([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* concussive_shot([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("concussive shot", /*P*/ nullptr, diff --git a/src/strategy/hunter/GenericHunterNonCombatStrategy.cpp b/src/strategy/hunter/GenericHunterNonCombatStrategy.cpp index 782b34e6..c4b7e83f 100644 --- a/src/strategy/hunter/GenericHunterNonCombatStrategy.cpp +++ b/src/strategy/hunter/GenericHunterNonCombatStrategy.cpp @@ -16,7 +16,7 @@ class GenericHunterNonCombatStrategyActionNodeFactory : public NamedObjectFactor } private: - static ActionNode* rapid_fire([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* rapid_fire([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("rapid fire", /*P*/ nullptr, @@ -24,7 +24,7 @@ class GenericHunterNonCombatStrategyActionNodeFactory : public NamedObjectFactor /*C*/ nullptr); } - static ActionNode* aspect_of_the_pack([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* aspect_of_the_pack([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("aspect of the pack", /*P*/ nullptr, diff --git a/src/strategy/hunter/GenericHunterStrategy.cpp b/src/strategy/hunter/GenericHunterStrategy.cpp index 6adb3ae1..0ad96011 100644 --- a/src/strategy/hunter/GenericHunterStrategy.cpp +++ b/src/strategy/hunter/GenericHunterStrategy.cpp @@ -19,7 +19,7 @@ class GenericHunterStrategyActionNodeFactory : public NamedObjectFactory } private: - static ActionNode* riposte([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* riposte([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("riposte", /*P*/ nullptr, @@ -28,7 +28,7 @@ class DpsRogueStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* mutilate([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* mutilate([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("mutilate", /*P*/ nullptr, @@ -36,7 +36,7 @@ class DpsRogueStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* sinister_strike([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* sinister_strike([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("sinister strike", /*P*/ nullptr, @@ -44,7 +44,7 @@ class DpsRogueStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* kick([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* kick([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("kick", /*P*/ nullptr, @@ -52,7 +52,7 @@ class DpsRogueStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* kidney_shot([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* kidney_shot([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("kidney shot", /*P*/ nullptr, @@ -60,7 +60,7 @@ class DpsRogueStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* rupture([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* rupture([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("rupture", /*P*/ nullptr, @@ -68,7 +68,7 @@ class DpsRogueStrategyActionNodeFactory : public NamedObjectFactory /*C*/ nullptr); } - static ActionNode* backstab([[maybe_unused]] PlayerbotAI* botAI) // unused param - whipowill + static ActionNode* backstab([[maybe_unused]] PlayerbotAI* botAI) { return new ActionNode ("backstab", /*P*/ nullptr, diff --git a/src/strategy/shaman/CasterShamanStrategy.cpp b/src/strategy/shaman/CasterShamanStrategy.cpp index 71186504..c5b56300 100644 --- a/src/strategy/shaman/CasterShamanStrategy.cpp +++ b/src/strategy/shaman/CasterShamanStrategy.cpp @@ -14,7 +14,7 @@ class CasterShamanStrategyActionNodeFactory : public NamedObjectFactory