From aaa9e1a42cb5c01a16cb40d75cb369eb28a0a707 Mon Sep 17 00:00:00 2001
From: bash <31279994+hermensbas@users.noreply.github.com>
Date: Mon, 29 Sep 2025 00:06:56 +0200
Subject: [PATCH] Placed cheap checks in isPossible() more expensive in
 isUseful()

combat en mounted are both HasUnitFlag checks, which are cheap calls to make.
---
 src/strategy/actions/NonCombatActions.cpp | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/strategy/actions/NonCombatActions.cpp b/src/strategy/actions/NonCombatActions.cpp
index 30842135..25c1fc47 100644
--- a/src/strategy/actions/NonCombatActions.cpp
+++ b/src/strategy/actions/NonCombatActions.cpp
@@ -51,15 +51,15 @@ bool DrinkAction::isUseful()
 { 
     return UseItemAction::isUseful() && 
         AI_VALUE2(bool, "has mana", "self target") &&
-        AI_VALUE2(uint8, "mana", "self target") < 100; 
+        AI_VALUE2(uint8, "mana", "self target") < 100 &&
+        !botAI->HasAnyAuraOf(GetTarget(), "dire bear form", "bear form", "cat form", "travel form",
+            "aquatic form","flight form", "swift flight form", nullptr) &&
 }
 
 bool DrinkAction::isPossible()
 {
     return !bot->IsInCombat() && 
         !bot->IsMounted() &&
-        !botAI->HasAnyAuraOf(GetTarget(), "dire bear form", "bear form", "cat form", "travel form", 
-            "aquatic form","flight form", "swift flight form", nullptr) &&
         (botAI->HasCheat(BotCheatMask::food) || UseItemAction::isPossible());
 }
 
@@ -105,14 +105,14 @@ bool EatAction::Execute(Event event)
 bool EatAction::isUseful() 
 { 
     return UseItemAction::isUseful() && 
-        AI_VALUE2(uint8, "health", "self target") < 100; 
+        AI_VALUE2(uint8, "health", "self target") < 100 &&
+        !botAI->HasAnyAuraOf(GetTarget(), "dire bear form", "bear form", "cat form", "travel form",
+            "aquatic form","flight form", "swift flight form", nullptr) &&
 }
 
 bool EatAction::isPossible()
 {
     return !bot->IsInCombat() && 
         !bot->IsMounted() &&
-        !botAI->HasAnyAuraOf(GetTarget(), "dire bear form", "bear form", "cat form", "travel form", 
-            "aquatic form","flight form", "swift flight form", nullptr) &&
         (botAI->HasCheat(BotCheatMask::food) || UseItemAction::isPossible());
 }