PVP Talents and InitGlyph changes
This PR adds 3 pvp specs for each class, as well as their glyphs. It also adds exceptions to the Initglyph function, based on pvp-based talents for each class.
conf\playerbots.conf.dist - Adds 3 pvp specs/glyphs for each class.
src\factory\PlayerbotFactory.cpp - InitGlyph in its current form is unable to correctly assign glyphs on specindexes (or tab) over 2 without an exception. That is why this exception already exists in the code:
if (bot->getClass() == CLASS_DRUID && tab == DRUID_TAB_FERAL && bot->GetLevel() >= 20 && !bot->HasAura(16931))
tab = 3;
This checks if the class is a Druid, if the tab is feral, if they are equal to or above level 20, and they don't have the Thick Hide talent. If all of these are true, then it manually sets the tab = 3. I first discovered this when I noticed that my frostfire mage would never be assigned the correct glyphs in the config - aka glyph of frosfire. It is because the frostfire spec is tab = 3, and no such logic exists. When I started adding the additional pvp specs, I noticed that they never would assign the correct glyphs. I had to add an exception to all pvp specs, and have them check for certain pvp related talents to correlate the tab manually. This is because tab is derived from the AiFactory::GetPlayerSpecTab(bot); function. The only possible tab values from this function are 0, 1, and 2.
**TLDR: Added code to support Frostfire Mage, dual-aura Blood DK, and all the PvP specs for correct glyph assignment.**
src\strategy\actions\ChangeTalentsAction.cpp: When you pick a spec with "talents spec" function, such as "talents spec arms pve", it will now correctly assign glyphs without the player having to execute the maintenance command. Setting the InitGlyphs to false removes prior glyphs.
src\strategy\actions\TrainerAction.cpp - Changed factory.InitGlyphs(true); to factory.InitGlyphs(false);. This makes it so all prior glyphs that were assigned are correctly deleted. I first noticed this when switching between specs and using the maintenance command - I had to login to the bot and manually delete the old glyphs, in order for the maintenance command to assign the new, correct glyphs.
* Corrections to Vanilla max iLevels
This reverts commit 681ec5c5b583dc935d60172f1790c6635eaef9ab, reversing
changes made to f4e6b1644ff2c3fa4b5f97a5b4d7cea14e352263.
* Corrections to Vanilla max iLevels
This is a complete overhaul of the warlock class, making 3 new strategies (affliction, demonology, and destruction), as well as finishing the warlock tank strategy (shadow ward and searing pain). It also includes a soulstone fix, where the bots can change who they soulstone based on the non-combat strategies you set for them. It also includes a self-resurrect action and trigger that allows the bots to resurrect using a soulstone or reincarnation. Many other skills were added to finish out the warlock skillset.
* ICC PP WIP
WIP
* added mutated plague for PP
* BPC added (kinetic and boss targeting need to be done by player)
OT collects dark nucles, bots spread on vortex and other stuff they do ok on their own.
Tested only on 10NM, should work on 25NM
* Tank pos. correction
* BQL, ranged spread, link, flame, bite, tanking tested 10NM
to do (better fire spread, hc tacti, melee spread when in air)
* LDW improved
improved shadow logic, ranged spread for easier shadow handling
* dbs update, fixed teleporting
Bots should only go and teleport to the mage that is actually below zero now
* DBS ranged fix
Ranged should spread more quickly and freak out less
* Festergut && DBS
fixed ranged spread (both)
fixed spore logic (fester)
* Rotface fix
Improved big ooze tanking (static pos, todo kiting)
ooze explosion spread mechanic fix
ooze pool fix
Player needs to mark rotface with skull icon, oterwise bots try to attack oozes
* BQL fixed for 25nm
todo: better melee logic in air phase, better melee flame spread
* VDW, Sister Svalna, Sindy update
Sister Svalna, bots can pickup spears and throw at svalna when she has shield up
VDW added healer strats to use portal and heal boss (atm druids are for raid healing only, so use druide + any other healer, ideally player should be healer)
todo (focus on supressers, add healer rotations, atm they use quickest spell they can)
Sindragosa
Added tank boss manipulation (boss orientation and position)
bots detect (buffet, unchained magic and chilled to the bone and act accordingly)
bots detect frost beacon move to safe spot and los frost bombs around them, while dpsing tombs (todo stop dps if only one tomb is left, if we have frost bombs around, not a big deal atm since in nm they dont one shot)
Last phase bots los behind tomb to loose buffet, tanks swap when they have hi buffet count.
Player should tell bots with skull rti if they should kill tomb or focus boss.
todo (dynamic tomb los in last phase so that healers can see tank but also hide behind tomb to break los from boss)
Removed some debug messages, improved LM spike action (nearest bots also try to help kill it)
Improved Lady Deathwshiper shade action (only targeted bots will run away instead of every bot that is near it)
dbs improved tank switch
I recommend to use 3 healers (just to be safe) and 2 paladin tanks (warr seems to struggle with agro) in 10 man
25 man 6-7 healers (just to be safe) Since most of the bosses are about survival and not dps
* LK Update (doable)
LK added
Improved tank switching for all bosses
Fixed PP gas cloud kiting
Malleable goo todo (dont know how to detect it since its not object or npc) just summon ranged bots to safe position to bypass
BPC fixed OT sometimes not tanking kele
kinectic bombs todo (for now player should take care of them)
Sindragosa fixed rare case when she is in air phase but tombs went to last phase position
LK
Bots can handle necrotic
Bots can handle adds
Bots should focus valkyre that actually grabbed someone (if unlucky and player just use attack command and summon bots to you if they are far away from you) if they grab bots you can either summon to make them useless or let bots cc them and do it legit way.
Defile should be watched by player and once it was cast just summon bots to you
Vile spirits for some reason go to the ground and get nuked by bots aoe spells so there is not much to be done
**Player needs to be alive the whole LK fight since you will have to watch out for frost spehers (sometimes bots ignore them), summon bots when defile is up and summon ranged bots if they get stuck near shambling or raging spirits since their aoe will wipe you)
all in all LK is doable both 10 and 25nm, player needs to have knowledge of lk fight and needs to know how to use multibot addon and make macros for eg summoning or commanding groups of bots or individual bots)
Dont forget frost/shadow/nature resist auras in whole ICC since it will help alot
I have done whole icc 10 and 25 with 2 pala tanks, 2/5 heals and rest dps, if you use +1 or +2 heals it should be easier (since I was testing I did close to 0 dmg in fights same with heals)
* fixed changes made by mistake
fix
* Malleable fix (simple spread mechanic)
Malleable mechanic added (simple spread for now)
Gas cloud fixed (Bots sometimes got stuck between puddle and kite location)
* Defile Update
Bots detect and avoid defile (they struggle to find a way back to the boss around it tho, use summon to help them)
Melee bots should be able to stand behind/to the flank of shambling/spirits
* GS fixed bots not returning to their ship for A and H
Bots will return back to ship after killing mage
* PP gas cloud kiting improved
PP gas cloud kiting improved
* BPC targeting fixed
Bots will mark valid prince with skull RTI now
* BQL added melee spread in air pahse
BQL added melee spread
* VDW healing rotation improved
Healers will now use strong heals and hots
* Fixed Necrotic Plague
Fixed issue with Necrotic where it would get dispelled too soon, or would not get dispelled at all
* LK Update
Refined defile logic
Added 3 points for ranged and melee in winter phase (east, west, south when facing throne)
fixed frost spheres targeting (hunter will focus them)
Atm bots will reset z axis if they fall underground or if they get teleported by lk
Better positioning in 1st phase
* 10HC update until PP
LK defile improved for 10nm (bots sometimes stood 2 close to defile until it grew few times)
Improved rotface for HC
PP remade for 10HC.
Gas cloud is now properly kited
Fixed a rare case of server crash when there were ooze and gas cloud alive at same time.
Bots will move around puddles according to its size now.
Bots that get unboud plague will simply move away from raid and die thus loosing it from raid.
Volatile ooze improved stacking.
Fixed ranged sometimes glitching thru walls when spreading out from other members.
10HC PP is now doable but its hard without summoning (summoning break gascloud and ooze targets so its easier to do). You need to watch boss so you dont phase 2 soon otherwise you will get 2x ooze and cloud which is almoust always a wipe. If abo is not played near perfection bots will struggle with oozes and gas clouds if they are not slowed on time. Always save energy to slow gas cloud since it will wipe the group if it reach its target.
Bots will sometimes stand in puddle, just command them to move and they will figure out what to do.
todo (proper malleable handling)
* Up until Sindy 10HC
BPC added shadow prison handling, bots stop moving if more than 12 stack, tanks more than 18
Improved spreading logic
VDW
fixed issue where bots in portal wold move at half speed compared to real player
* fixed accidental change
* LK 10HC update
Added Shadow trap logic
(if they stand in it, not a big deal since bots wont get yeeted only players will)
When harvest soul, only player will be in another dimension (you must survive)
**Sindy and LK can be done, but I must dissapoint purist, at my skill level I could not achieve to do HC without using summon or other "cheat" bot functions.
Other bosses are all doable now in 10hc
* ICC fixes GS, PP; BQL, SINDY
Minor fixes, bite action improved
* ICC improve Sindy
Bots will now choose non beacon position based on difficulty, 10/25
* ICC fixed missing A/H buff
Fixed missing ICC buff for A and H
Buff will only be present when logged on and in ICC, once any bot or player leave ICC the buff is gone to prevent abuse.
This will make ICC easier now and with recent DPS update and movement improvement bots will now actully do decent dps and even greater healing.
Ally buff
https://www.wowhead.com/wotlk/spell=73828/strength-of-wrynn
Horde buff
https://www.wowhead.com/wotlk/spell=73822/hellscreams-warsong
* revert last change
revert buff
* ICC improve Rotface
Bots will now mark Rotface with skull icon, which will make them focus boss instead of oozes automatically
* ICC Festergut 10 Man fix
There was a rare case in 10 Man when 2 tanks would get spores which made them both stack at melee spot. Now the code will check if any of the spored player is main tank, if it is, it will stay at melee and other spores will go at ranged spot since off tank doesn't really need to stand near main tank all the time.
* ICC BPC major update, fix and improve
Fixed main tank sometimes not tanking both bosses (vala and talda)
Improved marking of current prince
Empowered vortex: bots will now spread out when it is being cast, instead of always spreading(ranged). This will make melee also spread better now since bots will calculate and move to optimal positions.
Added Kinetic bomb handling.
Hunters will take care of bombs, if no hunter is present then any ranged dps will take care of kinetic bombs.
* ICC BQL/VDW major update + minor fixes/improvements
LDW improved spreading for ranged, tanks will move boss in the middle of the room now when shield is depleted which will make bots bug less around pillars
GS Assist tank will not teleport to enemy ship and will keep tanking adds on our ship now
DBS ranged spread improved (they will calcualte spot for each bot and stick with it reducing movment to minimum), fixed bug where in 25 man ranged bots would go behind walls, making them unable to dps boss, improved rune of blood tanking
Festergut ranged spread improved (they will calcualte spot for each bot and stick with it reducing movment to minimum)
BQL Melee spread improved, bite logic improved, added swarming shadows logic (not perfect but at least it wont be all over the room anymore), Tanks will properly handle blood mirror now
VDW boss and raid healers will be automatically assinged depening by number of healers(if more than 3 healers in group, 2 will focus on raid and others will heal boss, otherwise one healer will heal raid). Druid will be assigned to raid healing if no druid present then some other random heal class. Added rotations for druid healers if they end up healing the boss. Raid healers will not use portals anymore. Healers will come to the ground now after using portals (they were stuck in air)
* ICC LK minor update
PP
Removed pre stacking for ranged when volatile ooze spawn (they will kill it much faster now and only stack if someone actually gets targeted by ooze)
LK
Hunters will use trnaq shot to remove enrage from shamblings
Improved valkyr cc
Minimized ping-ponging during winter phase
* ICC minor Sindy improve
Reduced position tolerances and forced movement for beacon and non beacon positions which will make bots move to spot that they actually need to be at instead of randomly running to sindragosa or beaconed players.
* ICC minor update
GS
Bots will mark mage with skull rti
Rotface
Fixed bots glitching thru walls and floors (added check if position is valid before moving)
PP
Bots will mark volatile ooze with skull rti now which will help them focus it and kill asap (usefull for heroic when both volatile ooze and gas cloud are present at the same time)
VDW
Added default group position in the middle if the room so that bots don't spread out too much which will force them to focus supressers more
Fixed Boss healers not keeping themself alive when low on HP
* ICC LK minor update
Commented out z axis bypass since it was fixed with recent core updates.
Bots no longer fall thru buggy platforms so its no longer needed which in return makes valkyrs works as they should.
* ICC LM & LDW Improved
LM
Removed Attack Action since it was buggy and replaced it with RTI. (Improved DPS)
Simplified trigger for spike action, since attack logic is handled by skull RTI now.
Bots (tanks) will mark spikes with skull RTI, which will make bots instantly switch to Spike targets. If no spike is present, the boss will be marked.
Added logic that will make non-tank bots move away from LM to a fixed position behind LM if they happened to be in front of LM (No more insta kills with cleave).
If LM is casting Bone Storm, bots will ignore the above logic and do max dps.
LDW
Removed Attack Action since it was buggy and replaced it with RTI. (Improved DPS)
Bots (tanks) will mark adds with skull RTI, which will make bots instantly switch to adds targets. If no spike is present, the boss will be marked, which will help with keeping allies alive when they get mind controlled by LDW.
Moved 2nd phase position deeper into the room and reduced boss hp trigger to 95%, which will keep tanks where they should be during 1st phase (sometimes the boss dropped below 98% and tanks would ping pong around the room).
Ranged bots will now spread closer to each other now and will ignore spreading if they are 2 far or 2 close to the boss so they can properly reposition.
These changes should also fix recent bugs with bots not casting/standing still on LM and LDW.
* ICC DBS Improve
Replaced attack action with RTI. (Improved DPS)
Ranged bots will move away from blood beast if targeted by it now.
* ICC Sindragosa and LK Improve
Sindragosa
Improved tomb los for frost bombs. Bots will now mark tomb with moon rti to avoid killing it too soon. (If they still attack the tomb, simply reset and after bombs are over, simply attack the tomb to kill or mark with a skull.)
Main Tank will reset mystic buffet stacks now to avoid tank swapping since it's really unreliable which will make sindy less frustrating to kill (other bots will need to do mechanics properly by hiding behind ice tombs).
LK
Necrotic plague action
Bots will now check before moving to the Shambling if they are in front of the Shambling to avoid getting one shoted by shockwave.
Improved multiplier, which will now properly handle dispelling of necrotic plague.
Winter phase action
Bots will properly move behind adds to avoid getting one shoted by shamblings or raging spirits.
If there is a hunter in the grouphunter will focus on spheres; if not, any ranged DPS will focus spheres.
Adds action
Bots will now be in proper positions during the 1st phase, and when the off tank is done collecting shamblings, it will move away from the group.
Bots (non-tanks) will move behind the shambling if they are in front of it to avoid getting one shoted in the 1st phase.
Restored action for checking if bots are at ground level, since they were still sometimes glitching through the floor (valkrys will be able to carry bots and drop them off the edge if not killed in time).
Improved defile calculations for 10 man and 25 man raids since defile was growing differently for 10 and 25, which would make bots in 25 man move very far away from somewhat small defile puddle.
Bots will now properly CC any valkyr that wasn't CC'd, and they won't freak out anymore if multiple valkyrs are present. (They can't tell which valkyr is holding bots/ players, so we should command an attack on valkyrs that are holding someone.)
Bots will now run away from Vile Spirits if they are targeted by them during the last phase.
* ICC 25HC ldw shades fix
Fixed bots could not detect shade if there were multiple present
* ICC trigger optimization
Optimized trigger and action for:
KineticBomb
OozePuddle
* ICC LK Improve
Improved Shadow Trap, Winter phase and 1st phase.
Bots will now have fixed positions for 1st phase if no shadow trap is present.
Tanks will now take care of taunting adds during winter phase. (Assist tank will collect adds and bring them to main tank, main tank will take over the adds so we have minimal chance of adds rotating towards the raid)
Fixed shadow trap detection.
* ToC dungeon update
Added TOC dungeon strategies for 1st encounter.
Other encounters are pretty easy and straightforward so they do not require strategies. They can be all done with follow, reset, summon, attack, skull icon etc...
Bots (A/H) will automatically check if they have lance equiped or in inventory. If they don't have lance they will pick it up from nearest lance stand and equip it.
Bots will mount nearest mount if they have lance equipped.
Once mounted they will keep Defend aura at 3 stacks (top priority).
In fight they will cast charge if more than 5f away, they will cast shield break if target has Defended aura active and they will use Thrust if they cant use anything else.
In short they will melt any target and enemies wont stand a chance keeping their defend aura up.
Once champions are defeated bot will automatically equip best weapon they have in inventory (weapon that was swapped with lance)
* ICC minor update
LM
Bots will now move in smaller increments to get behind boss
They will still move towards fixed position, but as soon they are not in front of boss, they will stop moving and do other actions.
GS
Fixed cannon trigger, now will return true if cannon is 100f from bots.
It used to return true all the time.
* ToC added Eadric strat
bots will look away during radiance cast
* ICC LK minor fix
fixed crash in icclichkingsaddsaction
* ICC GS fix
While encountering edge case when playing horde, the logic was to detect mages, there are usually 2 around, but the longer the fight last the bigger the chance that cannons would kill all the mages thus once we kill the mage that was casting deep freeze bots could not execute action that would return them back to the ship, so the boss had the time to nuke them one by one.
Even tanks have hard time surviving the boss.
I have changed it now (both A/H) so that we keep track of the enemy boss (which is hard if not impossible to kill as main trigger) and we are keeping track of the mage that is actually casting deep freeze, we mark it with skull, and now as soon the mage is dead, bots will remove the mark so there is 0 confusion about what to do next on their side, and they will come back asap.
* FoS Improved and fixed, ICC LM, LDW and PP updates
FoS
Improved/fixed triggers, Improved/fixed actions.
Bronjahm
Tank will properly kite soul fragment around the room
Replaced attack action with skull rti to focus soul fragments
Non-tank bots will only try to stay within 10f of boss only once we enter last phase, tank will be in the middle of the room if it is not kiting soul fragment
Devourer of Souls
DPS bots will stop dps if boss is casting mirrored soul
Laser can be easily avoided with follow/summon
ICC
LM
Tank will only move to tank position if it actually have the agro, it used to move there without agro and few of the bots would get killed since tank was unable to reach bot
LDW
Fixed edge case where tank would be target of shade and it would be unable to move away it from it due to tank position restrictions, now if Tank is targeted by shade it will be able to move and run away from it (in hc this could cause wipes since explosion is aoe + tons of dmg)
PP
When oozes spawn, tank will move towards green ooze spawn to keep raid near green ooze (faster kill) and far away from gas cloud (better chance to kill if abo didn't manage to slow it)
* PoS Strategies
Ick and Krick
All boss mechanics implemented
Forgemaster Garfrost
Easily doable with follow/stay/summon
Scourgelord Tyrannus
Ranged bots will spread so that they all don't get frozen by dragon
They avoid everything else on their own
* ICC Refactor, All bosses improved NM and HC
Major Update
* Update playerbots.conf.dist
* Do not disband alt bots group when master goes away
* This update makes the original PR functionality optional, which prevents alternative bots (random bots) from automatically leaving the group when the master leaves.
* Fix
---------
Co-authored-by: bash <31279994+hermensbas@users.noreply.github.com>
* Make variable name more intuitive
* Make variable name more intuitive
* Make variable name more intuitive and clarify function
* Update playerbots.conf.dist
* Update PlayerbotAIConfig.cpp
* Update PlayerbotAIConfig.h
* Update RandomPlayerbotMgr.cpp
* Update playerbots.conf.dist
* Update playerbots.conf.dist
* Update playerbots.conf.dist
* Update playerbots.conf.dist
* Update playerbots.conf.dist
* Update playerbots.conf.dist
* Make variable name more intuitive
* Make variable name more intuitive
* Make variable name more intuitive and clarify function
* Update playerbots.conf.dist
* Update playerbots.conf.dist
* Update playerbots.conf.dist
* Update playerbots.conf.dist
* Update playerbots.conf.dist
* feat(playerbots): staggered taxi take-off for bots
Adds four new configurable settings to playerbots.conf:
- AiPlayerbot.BotTaxiDelayMinMs: Min random delay before the 1st follower bot clicks the flight-master
- AiPlayerbot.BotTaxiDelayMaxMs: Upper bound for the overall taxi delay window – larger spreads big raids
- AiPlayerbot.BotTaxiGapMs: Fixed gap added per group-slot so bots never take off together
- AiPlayerbot.BotTaxiGapJitterMs: Extra small randomness added to each gap so launches don’t look robotic
These options allow server owners to fine-tune how bots queue up and take off from flight masters, making their behavior appear more natural.
Closes#1017 : Bots use Flight master nearly the same time.
* fixed build errors
Was missing a header and variable declarations.
* Add table to store the security keys for accounts.
* Add table to store relationships between accounts.
* Add a new configuration option to enable or disable trusted account bots.
* add checks for linked accounts
* Handle account linking and chat commands
* fix uppercase typo
* change query & fix chatcommandtable
* add missing functions to header
* move account linking to updates dir
* moved table creation to correct updates folder
* use playerbots db instead of character db
* fix db
* fix install?
* remove duplicated logic and add hashing to stored securityKey
* add object before call
* change chat variable
* rename SQL file for correct execution order
* add header include for ubuntu compatibility
* remove old sql
* Add addclass bots to trading list, differentiate between buying and selling.
* typos
* Try calling playerguid
* point IsAddclassBot to IsRandomBot
* typo
* Fix through IsAddClassbot
* Working Version
* Minor typos.
* Add RandomBotMinLevelChance
* Save mana only for healer
* Disable addclass dk for low level player
* Target selection and debuff cast with less players in group
* Change default rpg strategy and bots count in config
* Logs clean up
* Improve init=auto
* Remove login logs after initialization
* Rndbots stats for quest
* Prediction chase in reach combat
* Poor & Normal items ensurence for init=auto
* Takes bot rotation into account and adjust accordingly when enabled as it requires to be higher than MaxRandomBots to function properly.
* Correct default config to reflect that bots pool size for rotation should be higher than MaxRandomBots
* Revert space at start of all lines.
* Remove RandomBotAccountCount requirement
* Remove RandomBotAccountCount
* Remove randomBotAccountCount
* Remove randomBotAccountCount
* Update playerbots.conf.dist
* Style
* Set RotationPoolSize to 20 to work with the bot amount defaults
* Update PlayerbotAIConfig.cpp: Sync with default config
* Set +1 where appropriate
* Acc patch (#73)
* Account for TBC
* Still made it possible to change manually if desired
* uint32 randomBotAccountCount;
* Update Playerbots.cpp
* Update RandomPlayerbotMgr.cpp
* Update playerbots.conf.dist
* Update PlayerbotAIConfig.h
* Update PlayerbotAIConfig.cpp
* Update playerbots.conf.dist
* Update playerbots.conf.dist
* Updated information
* Update RandomPlayerbotMgr.cpp
Avoid reverting https://github.com/liyunfan1223/mod-playerbots/pull/870/files
* Update playerbots.conf.dist
set capitals on Random
* Final update on settings documentation
* Update playerbots.conf.dist
* Fix bots loving to do BG's a bit too much
* Final fix bots over-queuing
* pt2 - Limit over-queuing to ~1 instance
Try and prevent over-queuing to a max of 1 instance.
* Add new queue instead of instance if necessary
* Update RandomPlayerbotMgr.cpp
* Final commit
* Update RandomPlayerbotMgr.cpp
* Fix timer
* Updated docu
* Update playerbots.conf.dist
* Update RandomPlayerbotMgr.cpp
Set BgCheckTimer to 45 as it is sufficient.
