fix: minor optimization

This commit is contained in:
Gozzim
2022-05-31 00:16:12 +02:00
parent 6389cceaea
commit 48219cf358
2 changed files with 2 additions and 6 deletions

View File

@@ -566,7 +566,7 @@ bool Transmogrification::SuitableForTransmogrification(ObjectGuid guid, ItemTemp
if (!CheckPureProtoRequirements(proto)) if (!CheckPureProtoRequirements(proto))
return false; return false;
ObjectGuid::LowType playerGuid = guid.GetCounter(); auto playerGuid = guid.GetCounter();
CharacterCacheEntry const* playerData = sCharacterCache->GetCharacterCacheByGuid(guid); CharacterCacheEntry const* playerData = sCharacterCache->GetCharacterCacheByGuid(guid);
if (!playerData) if (!playerData)
return false; return false;

View File

@@ -120,12 +120,8 @@ public:
} }
auto guid = player->GetGUID(); auto guid = player->GetGUID();
CharacterCacheEntry const* playerData = sCharacterCache->GetCharacterCacheByGuid(guid); uint32 accountId = sCharacterCache->GetCharacterAccountIdByGuid(guid);
if (!playerData)
return false;
uint32 itemId = itemTemplate->ItemId; uint32 itemId = itemTemplate->ItemId;
uint32 accountId = playerData->AccountId;
std::stringstream tempStream; std::stringstream tempStream;
tempStream << std::hex << ItemQualityColors[itemTemplate->Quality]; tempStream << std::hex << ItemQualityColors[itemTemplate->Quality];