* update spell attribute descriptions primary from TC, secondary from Wowdev Wiki (not guaranteed to be correct for 335)
* show all attributes on SpellDetailPage
* update links from attributes to SpellFilter
* unsure: should the attribute filters work purely on attributes or also consider other factors?
* implement some of the client side modifiers on the spell tooltips and buffs
* followup on 748a78c3c7
* fix return type of criteria filter callbacks (mostly in case of faulty input)
* spread the criteria var into criteria filter callbacks
* some magic numbers to constants and type declarations for params/return types
* add 'fished' as valid item source
* item source 'none' now properly selects items without source, not items without source from this list
* fixed edgecases where filter callback might have no return value
* update events and actions to match TrinityCore again
* removed events and actions have been kept but marked as deprecated
* general rewording and use of UIES for better readability
* move constants to respective classes
* reevaluate usage of UNIT_FIELD_BYTES1 content
* detatch from User and Util and move to its own enum class
* added definitions for all locales the 12340 client could in theory have
* this is incompatble with the Intl extension
* version bump and php requirement bump
* do not use NULL on item stats as it prevents searching for an amount of 0 (except for stats that certain items just cant have)
* fix stats from spells granting spell power and spell healing separately
* define and use some item subclasses
* fix empty scaling bar
* fix setting max level for scaling tooltips
* fix displayed periodic power gain value for runic power and rage
* attempt to fix spell coefficient calculation (dear god...)
* append % sign to value for two more auras
* display value per combo point
* fix usage of generic search wildcards: ? *
* only transform search form fields expected to be text
* some cleanup (magic numbers to define, fn return types, nullsafe assignemnts)
* changed logic to not display required arena rating in tooltip or infobox if there are sources that don't require it.
* also, should there be a difference in sources, display lowest required rating, not not highest.
* do not display crafted item tooltip inside recipe tooltip if the craft spell doesn't create an item.
(notably: enchantments were displaying enchantment scrolls)
* always display reagent cost if set
* fixed several deprecation notices and warnings from MySQL8, most notably:
- SQL_CALC_FOUND_ROWS: stopped using DBSimple::selectPage and query 'SELECT COUNT(*) ...' separately where needed
- ON DUPLICATE KEY UPDATE ... VALUES(): use row alias for new values instead of VALUES function
- boolean shorthands to long form (&& -> AND, etc)
* split completion table into it's subcomponents
* this should save some disk space as some keys and null fields have been optimized out and col sizes have been reduced
* sort ICC raid bosses first to last
* spell: resolve MiscValue for SPELL_AURA_MOD_INVISIBILITY
* search: do not double escape page title
* profiler: fixed typo, causing shaman spirit weapons to be applied _everywhere_
* define magic numbers from combat ratings
* move forgotten rating base values from Util to Stats
* fix localized rating strings for item and spell tooltips (expected float, got string)
* some cleanup in item/spell types to make it more clear when an internal stat is being handled, not an itemMod or combatRating
* prevent direct access to some internal files where applicable and reword error for others
* if CFG_DEBUG is set also enable debug in client javascript
* non-breaking formatting changes
* define regions and missing locales for later use
* unify stat handling. If there are discrepancies left at least they are now centralized.
- health should no longer pretend to be mana
- stats are no longer capped to 32.7k points as items can have multiple of the same stat and handily exceed smallints
* weight scale fixes:
- "repair cost" is no longer a weight scale option. Why was it one in the first place? Also it wasn't even accessible before. (that was a bug)
- "bonus armor" is now searchable and only applied to armor pieces
* removed unused parsed stats from itemsets
* relax numeric type requirements when working with filters
* restore smart type casting functionality of Util::checkNumeric when used with NUM_ANY
* enable Util::arraySumByKey to work recursively
* fix source display in listview
* Conditions: loot rows initially have no 'id'
* fixed building talent string for hunter pets (different talents can occupy the same row/col spot)
* added keys loot cols on creature table
* fixed trying to show itemset type for itemsets without type
* fixed waypoint calculation when moving entity between floors
* rewritten and moved to its own class, should be easier to expand in the future
* add missing sources and types from TrinityCore
* implement conditions on Areatrigger and Loot containers
* implement reverse lookups (e.g. a spell is a conditional for something else)
* general beautification pass .. should be more legible in general
NOTE:
* texts have been changed, so the existing translation for esES ist gone
* selecting and describing condition targets is still wonky
* convert configuration from list of constants to object
* fixes config changes not applying on cli whithout closing and reopening again
* config variables are no longer embedded in localization text
* enable level scaling for spells with RealPointsPerLevel
* note: While BasePoint vars ($m, $M) can scale, they are often involved in formulas that would have to be recalculated in javascript. This is currently impossible. So this var is skipped for now.
* fixed misc issues Intellisense was nice enough to highlight.
* mostly deprecated usage of uninitialized parameters
* class GenericPage still needs a long, hard look and a refactor
* so, apparently the client allows ui escape sequences in the weirdest of places. Guess i have to follow suit.
* also, the sequences can be multiline
* also also, the file extension for icons is optional
* fixed "modefied-by" and "modifies" tab having different results
* evalueate some more spell effects
* replace magic numbers with defined strings
* get model info from some more spell auras
