yolinlin/azerothcore-wotlk-pbot
1
0
Fork 0
mirror of https://github.com/mod-playerbots/azerothcore-wotlk.git synced 2025-11-29 17:38:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore. Avoid failures in the tests of custom items (#18519)

Browse Source 
* chore. Avoid failures in the tests of custom items

* Report error but continue with the rest of the item

* change LOG_ERROR for LOG_DEBUG
This commit is contained in:
Walter Pagani
2024-03-15 20:09:10 -03:00
committed by GitHub
parent 9e5f65c548
commit 64f372fca3
1 changed files with 40 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

79
src/server/game/Globals/ObjectMgr.cpp
View File

@@ -2868,49 +2868,50 @@ void ObjectMgr::LoadItemTemplates()
// Checks // Checks
ItemEntry const* dbcitem = sItemStore.LookupEntry(entry); ItemEntry const* dbcitem = sItemStore.LookupEntry(entry);
if (dbcitem) if (!dbcitem)
{ {
if (enforceDBCAttributes) LOG_DEBUG("sql.sql", "Item (Entry: {}) does not exist in item.dbc! (not correct id?).", entry);
continue;
}
if (enforceDBCAttributes)
{
if (itemTemplate.Class != dbcitem->ClassID)
{ {
if (itemTemplate.Class != dbcitem->ClassID) LOG_ERROR("sql.sql", "Item (Entry: {}) has wrong Class value ({}), must be ({}).", entry, itemTemplate.Class, dbcitem->ClassID);
{ itemTemplate.Class = dbcitem->ClassID;
LOG_ERROR("sql.sql", "Item (Entry: {}) has wrong Class value ({}), must be ({}).", entry, itemTemplate.Class, dbcitem->ClassID); }
itemTemplate.Class = dbcitem->ClassID; if (itemTemplate.SubClass != dbcitem->SubclassID)
} {
if (itemTemplate.SubClass != dbcitem->SubclassID) LOG_ERROR("sql.sql", "Item (Entry: {}) has wrong Subclass value ({}) for class {}, must be ({}).", entry, itemTemplate.SubClass, itemTemplate.Class, dbcitem->SubclassID);
{ itemTemplate.SubClass = dbcitem->SubclassID;
LOG_ERROR("sql.sql", "Item (Entry: {}) has wrong Subclass value ({}) for class {}, must be ({}).", entry, itemTemplate.SubClass, itemTemplate.Class, dbcitem->SubclassID); }
itemTemplate.SubClass = dbcitem->SubclassID; if (itemTemplate.SoundOverrideSubclass != dbcitem->SoundOverrideSubclassID)
} {
if (itemTemplate.SoundOverrideSubclass != dbcitem->SoundOverrideSubclassID) LOG_ERROR("sql.sql", "Item (Entry: {}) does not have a correct SoundOverrideSubclass ({}), must be {}.", entry, itemTemplate.SoundOverrideSubclass, dbcitem->SoundOverrideSubclassID);
{ itemTemplate.SoundOverrideSubclass = dbcitem->SoundOverrideSubclassID;
LOG_ERROR("sql.sql", "Item (Entry: {}) does not have a correct SoundOverrideSubclass ({}), must be {}.", entry, itemTemplate.SoundOverrideSubclass, dbcitem->SoundOverrideSubclassID); }
itemTemplate.SoundOverrideSubclass = dbcitem->SoundOverrideSubclassID; if (itemTemplate.Material != dbcitem->Material)
} {
if (itemTemplate.Material != dbcitem->Material) LOG_ERROR("sql.sql", "Item (Entry: {}) does not have a correct material ({}), must be {}.", entry, itemTemplate.Material, dbcitem->Material);
{ itemTemplate.Material = dbcitem->Material;
LOG_ERROR("sql.sql", "Item (Entry: {}) does not have a correct material ({}), must be {}.", entry, itemTemplate.Material, dbcitem->Material); }
itemTemplate.Material = dbcitem->Material; if (itemTemplate.InventoryType != dbcitem->InventoryType)
} {
if (itemTemplate.InventoryType != dbcitem->InventoryType) LOG_ERROR("sql.sql", "Item (Entry: {}) has wrong InventoryType value ({}), must be {}.", entry, itemTemplate.InventoryType, dbcitem->InventoryType);
{ itemTemplate.InventoryType = dbcitem->InventoryType;
LOG_ERROR("sql.sql", "Item (Entry: {}) has wrong InventoryType value ({}), must be {}.", entry, itemTemplate.InventoryType, dbcitem->InventoryType); }
itemTemplate.InventoryType = dbcitem->InventoryType; if (itemTemplate.DisplayInfoID != dbcitem->DisplayInfoID)
} {
if (itemTemplate.DisplayInfoID != dbcitem->DisplayInfoID) LOG_ERROR("sql.sql", "Item (Entry: {}) does not have a correct display id ({}), must be {}.", entry, itemTemplate.DisplayInfoID, dbcitem->DisplayInfoID);
{ itemTemplate.DisplayInfoID = dbcitem->DisplayInfoID;
LOG_ERROR("sql.sql", "Item (Entry: {}) does not have a correct display id ({}), must be {}.", entry, itemTemplate.DisplayInfoID, dbcitem->DisplayInfoID); }
itemTemplate.DisplayInfoID = dbcitem->DisplayInfoID; if (itemTemplate.Sheath != dbcitem->SheatheType)
} {
if (itemTemplate.Sheath != dbcitem->SheatheType) LOG_ERROR("sql.sql", "Item (Entry: {}) has wrong Sheath ({}), must be {}.", entry, itemTemplate.Sheath, dbcitem->SheatheType);
{ itemTemplate.Sheath = dbcitem->SheatheType;
LOG_ERROR("sql.sql", "Item (Entry: {}) has wrong Sheath ({}), must be {}.", entry, itemTemplate.Sheath, dbcitem->SheatheType);
itemTemplate.Sheath = dbcitem->SheatheType;
}
} }
} }
else
LOG_ERROR("sql.sql", "Item (Entry: {}) does not exist in item.dbc! (not correct id?).", entry);
if (itemTemplate.Quality >= MAX_ITEM_QUALITY) if (itemTemplate.Quality >= MAX_ITEM_QUALITY)
{ {