Commit Graph

13783 Commits

Author SHA1 Message Date
Grimdhex
574ef5203a chore(Apps/CodeStyle): rewrite Ci-codestyle in python (#19714)
* initial version

* port most current checks

* allow to specify for each checks the exclude files

* Update _ci-codestyle.py

* fix trailing whitespace check and the error_handler logic

* optimize the script to parse all files only one time

* restore the error handling after that all checks are passed

* fix double blank lines at the end of the file

* improve outputs and the codestyle

* .

* update github workflow to the new script

*drop the old ci-codestyle
*move and rename the python script

* use getcwd instead abspath to define src_directory where the script is launch

* test for github workflow

* few cleanup

* fix the logic with the result output

* remove GetTypeId from the output result

* restore GetTypeId() check

* fix reviews

* remove GetTypeId check for gameobjects

*not currently fixed in the core

* fix type hint for file parameters

* remove the test file
2024-08-27 06:19:13 -03:00
Andrew
126f3a31ee refactor(Scripts/BlackTemple): Update the Illidari Council script to the new registration method (#19744)
refactor(Scripts/BlackTemple): Update Illidari council to new model
2024-08-26 16:28:48 -03:00
Andrew
83f8871c31 refactor(Core/BossAI): Improve the ScheduleHealthCheck() code (#19743)
* refactor(Core/BossAI): Improve the ScheduleHealthCheck() code

* Update ScriptedCreature.cpp

---------

Co-authored-by: sudlud <sudlud@users.noreply.github.com>
2024-08-26 14:44:05 -03:00
sudlud
4ed1815de6 fix(apps/installer): update for Ubuntu 22.04/24.04 with mysql 8.4 LTS (#19737) 2024-08-26 17:29:12 +02:00
github-actions[bot]
6bd29e7f93 chore(DB): import pending files
Referenced commit(s): 651f159fc5
2024-08-26 15:11:48 +00:00
daobashun
651f159fc5 fix(DB/Creature): Added dialogue for the mob "Pilot Bellowfiz" (1378) when idle (#19732)
* Add conversations when you're idle

* fix error

* fix

* Update rev_1724552482874297000.sql

The modification range has been increased from 10 yards to 15 yards

* Update rev_1724552482874297000.sql

---------

Co-authored-by: sudlud <sudlud@users.noreply.github.com>
2024-08-26 17:10:53 +02:00
Andrew
9ce2b23df3 refactor(Scripts/RuinsOfAhnQiraj): Clean up Ayamiss script (#19742) 2024-08-26 10:04:11 -03:00
Tereneckla
f2ed6f791b fix (Core/Unit): add AutoRpeatSpell delay to Auto Shot as well (#19603)
Update Unit.cpp
2024-08-26 07:20:23 -03:00
github-actions[bot]
5da709218d chore(DB): import pending files
Referenced commit(s): 52cd493ad8
2024-08-26 04:26:01 +00:00
Andrew
52cd493ad8 fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by dama… (#19730)
* fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by damage taken mods

* Create rev_1724540286668312700.sql

* Update spell_generic.cpp

* update to new format
2024-08-26 01:25:10 -03:00
github-actions[bot]
4fcc7d9085 chore(DB): import pending files
Referenced commit(s): 3062db6a9e
2024-08-26 02:46:24 +00:00
Grimdhex
3062db6a9e fix(DB/SAI): Twilight Prophet - Incorrect target type resulting to an… (#19614)
* fix(DB/SAI): Twilight Prophet - Incorrect target type resulting to an instant evade

* fix a software mistake in the query generation

* fix the delete query with current standard
2024-08-25 23:45:24 -03:00
Saqra1
68402b6d91 fix(Core/Spell): Reset cd on some channeled spells (#19696)
If a spell is both channeled and has SPELL_ATTR0_COOLDOWN_ON_EVENT
attribute (only rituals) is channeled for its full duration, it goes on
an infinite cooldown. The client needs to be notified when the ritual
ends without being completed.
2024-08-25 23:43:01 -03:00
Kitzunu
1bfcc0e469 fix(Core/BG): Fix fmt issue for bg sent notifications (#19718)
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19559
2024-08-25 19:22:37 -03:00
Andrew
c5399509e6 refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script (#19736)
* refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script

* Update boss_cthun.cpp

* Update boss_cthun.cpp
2024-08-25 16:46:24 -03:00
github-actions[bot]
a470971a5d chore(DB): import pending files
Referenced commit(s): 3463ff7444
2024-08-25 19:29:19 +00:00
kamenitxan
3463ff7444 fix(DB/RP): Add missing RP for Recover the Cargo! (#19611)
* Create gossip_8934.sql

fix(DB/Gossip): adds missing gossip for Recover the Cargo!
author ZenoX92 from TrinityCore

* fix(DB/gossip): fixes (#17196) Replace Repaired Diving Gear

* fix(DB/gossip): fixes (#17196) correct code style

* fix(DB/RP): adds missing RP for Recover the Cargo!
Author ZenoX92 from TrinityCore

---------

Co-authored-by: ZenoX92 <carlos.morales@insmet.cu>
2024-08-25 21:28:22 +02:00
Carriola-wotlk
4a14c61a90 fix(Scripts/BlackTemple) Gathios the Shatterer shouldnt use the same spell twice in a row (#19672)
* fix: SelectTargetMethod Random replaced with MaxThreat

* restore like origin

* fix: random spell casting replaced with alternating spells casting

* fix: alternating casting of aura, blessing and seal spells

* refactor: randomized toggle initialization refactored

---------

Co-authored-by: MattiaBallarini <ballarini.mattia1990@gmail.com>
2024-08-25 10:01:37 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
sudlud
d4aca0bca1 fix(apps/installer): update for Debian 12 using mysql (#19649)
* fix(apps/installer): update for Debian 11 and 12 using mysql

* drop Debian 11 due to OpenSSL 1.1.1 beeing deprecated already
2024-08-24 20:29:32 +02:00
sudlud
30a790117b fix(Core/WorldSocketMgr): sync default Network.OutUBuff with worldser… (#19702)
* fix(Core/WorldSocketMgr): sync default Network.OutUBuff with worldserver.conf.dist

* Update WorldSocketMgr.cpp
2024-08-23 06:38:00 +02:00
Tereneckla
3419f0246b fix (Core/Spells) partially revert #19529 (#19703)
Update Spell.cpp
2024-08-22 20:36:39 -03:00
Andrew
c0b6eae0e1 fix(Core/Spells): Fix movement impairment auras not being removed (#19684) 2024-08-22 15:09:43 -03:00
github-actions[bot]
7037108e9c chore(DB): import pending files
Referenced commit(s): 497d1ac0cb
2024-08-22 17:30:17 +00:00
Blackbird102
497d1ac0cb fix(DB/Quest): deeprun rat roundup (#19573)
added deeprun rat roundup fix for smartscripts
2024-08-22 19:29:24 +02:00
github-actions[bot]
e7580edfb4 chore(DB): import pending files
Referenced commit(s): dd41692a8e
2024-08-22 17:28:08 +00:00
Andrew
dd41692a8e fix(Scripts/SethekkHalls): Prevent multiple spawns of Anzu (#19636)
* fix(Scripts/SethekkHalls): Prevent multiple spawns of Anzu

* Update instance_sethekk_halls.cpp

* Update instance_sethekk_halls.cpp

* Update rev_1723763212128826500.sql
2024-08-22 19:27:15 +02:00
Kitzunu
eb410d6ab2 refactor(Core/Battleground): rewrite SpiritOfCompetitionEvent() (#19675)
* Use DoForAllPlayers

* Change to void - we don't need to return a value

* Better readability
2024-08-22 19:24:08 +02:00
github-actions[bot]
de1e42bd83 chore(DB): import pending files
Referenced commit(s): 7932130515
2024-08-21 16:30:43 +00:00
brankkoo
7932130515 fix(sql): added end RP for Harlan Needs a Resupply Quest (#18897) 2024-08-21 18:29:47 +02:00
Grimdhex
db7183a573 chore(Debug/Scripting): improve debug errors during the unloading scripts (#19643)
* chore(Debug/Scripting): improve debug errors during script unloading

* add the script name to increase debug informations and ensure to derefence script pointers
2024-08-21 08:13:20 -03:00
Andrew
ef4e0c0d4a fix(Core/Spells): Power of the Guardian should persist through death (#19638) 2024-08-21 06:36:05 -03:00
github-actions[bot]
0f80a41cb6 chore(DB): import pending files
Referenced commit(s): 82db30868b
2024-08-20 02:18:09 +00:00
Andrew
82db30868b fix(Scripts/BlackTemple): Fatal Attraction (#19641)
* Fix it not being cast if no valid targets are available
* Apply Patch 2.2 nerfs
2024-08-19 23:17:17 -03:00
github-actions[bot]
c08aad6303 chore(DB): import pending files
Referenced commit(s): 0d0b0a387a
2024-08-19 22:10:27 +00:00
Benjamin Jackson
bc5ae023d5 fix(DB/Creature): Correct Greater Fire Elemental template values. (#19686)
* Init.

* Add additional sniffed values.

* Add damage modifier default.
2024-08-19 19:10:03 -03:00
github-actions[bot]
0d0b0a387a chore(DB): import pending files
Referenced commit(s): 9d76ec6c09
2024-08-19 22:09:34 +00:00
Grimdhex
9d76ec6c09 fix(DB/SAI): Hemathion spells and timers (#19621)
* fix(DB/SAI): Hemathion spells and timers

* correct the devour spell cast condition

* forget to delete the old devour line
2024-08-19 19:08:39 -03:00
Saqra1
087acc58bf fix(Core/PetHandler): Allow PetAI to handle flags (#19446)
When a pet ability was cast, PetHandler reset all CharmInfo flags before
calling PetAI methods, setting the attack flag to true every time.
This commands the pet to go and chase the target which is not correct
when the state is COMMAND_STAY.

PetAI already handles the scenario, it just wasn't getting the actual
pet attack state.
2024-08-19 13:15:39 -03:00
Kitzunu
337135bf9e refactor(Core/Misc): Use NpcFlag helpers (#19676)
* chore(Core/Misc): Use HasNpcFlag instead of HasFlag

* extend to all npcflag helpers
2024-08-19 10:17:02 +02:00
github-actions[bot]
1275b64ef0 chore(DB): import pending files
Referenced commit(s): cccd8005e8
2024-08-19 04:30:38 +00:00
Andrew
cccd8005e8 fix(DB/Creature): Essence of Desire & Essence of Suffering taunt immu… (#19682) 2024-08-19 06:29:44 +02:00
Carriola-wotlk
01c8344cc8 fix(Scripts/BlackTemple): Gathios the Shatterer shouldnt use Hammer of Justice on random players (#19653)
* fix: SelectTargetMethod Random replaced with MaxThreat

* restore like origin

* fix: cast Hammer Of Justice on current target instead random target

* refactor: case EVENT_SPELL_HAMMER_OF_JUSTICE statement refactored

* refactor: if statement splitted

* refactor: last space removed

* Update src/server/scripts/Outland/BlackTemple/illidari_council.cpp

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* fix redundant check and new line

---------

Co-authored-by: MattiaBallarini <ballarini.mattia1990@gmail.com>
Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
2024-08-18 21:06:45 -03:00
Tereneckla
79a653b13e fix (Core/Spells): remove object size for hit calculation of aoe aura spells that target enemies (#19529)
remove object size for aoe on enemy spells
2024-08-18 20:34:56 -03:00
github-actions[bot]
1908ede1b5 chore(DB): import pending files
Referenced commit(s): b0f77eb39b
2024-08-18 23:32:50 +00:00
Grimdhex
b0f77eb39b fix(DB/SAI): Aether Ray spells and timers (#19620) 2024-08-18 20:31:55 -03:00
Andrew
23f58016d0 fix(Core/Map): Exempt raids from the hourly limit (#19650) 2024-08-18 19:56:38 +02:00
Yunfan Li
d436f97ea2 fix(Script/Vehicles): The next player entering Salvaged Siege Engine … (#19674)
fix(Script/Vehicles): The next player entering Salvaged Siege Engine should control turret if it's not occupied.
2024-08-18 14:28:56 -03:00
Grimdhex
a0689fb4ef fix(Dep/Boost): corrects a warning about path changes in boost process (#19629) 2024-08-18 13:39:06 +02:00