Add optional_unobtainable_items.sql

fix compiler warnings

sql/world/base/optional_small_group_adjustments.sql

@@ -0,0 +1,17 @@
+/* These changes are intended to be used in conjunction with autobalance, NPCBots, or other methods that allow players to complete raids with smaller groups.
+   Given the nature of the module, it is not uncommon for players to be in different phases and to have difficulty finding a full group, particularly for 40-man raids.
+ */
+
+ /* -- Earlier access to Eternal Quintessence --
+    This change will cause Duke Hydraxis to give Eternal Quintessence at the time he would normally give standard Aqual Quintessence, along with removing its cooldown.
+
+    This will allow players to have the full Molten Core experience including progress through the Hydraxian Waterlords faction and all quests with appropriate rewards,
+    while still allowing them to douse runes. Originally, due to the standard Quintessence being unique and having a week long cooldown, accessing the end bosses of the instance
+    requires one player per boss to douse the runes.
+
+    One other alternative provided by the module is the disabling runes entirely, which allows players to skip the faction and quests entirely and clear the instance as soon
+    as they enter the first time. This is done through the module's config file (disabled by default). This optional change is a medium between the two.
+*/
+
+UPDATE `smart_scripts` SET `action_param1` = 22754 WHERE `entryorguid` = 13278 AND `id` = 1;
+UPDATE `item_template` SET `spellcooldown_1` = 0, `spellcategorycooldown_1` = 0 WHERE `entry` = 22754;

sql/world/base/optional_unobtainable_items.sql

@@ -0,0 +1,14 @@
+/* These changes add otherwise unobtainable items to appropriate places in the world, with suitable levels of challenge to obtain them.
+   This is in line with the module's intent to allow each player to experience all of the available content in WoW - in this case,
+   it removes reliance on out-of-game events, real money purchases, or cheating via GM commands.
+
+   These items are almost entirely cosmetic and were available to players through external means - debug or cheat items not intended for player use are not added.
+ */
+
+/* Tabard of Flame (WoW TCG Promotional Item) - added as a 3% drop from Ragnaros */
+DELETE FROM `creature_loot_template` WHERE `Entry`=11502 AND `Item`=23705 AND `Reference`=0 AND `GroupId`=0;
+INSERT INTO `creature_loot_template` (`Entry`, `Item`, `Reference`, `Chance`, `QuestRequired`, `LootMode`, `GroupId`, `MinCount`, `MaxCount`, `Comment`) VALUES (11502, 23705, 0, 3, 0, 1, 0, 1, 1, NULL);
+
+/* Celestial Steed (Real Money Purchase) - added as a 1% drop from Gift of the Observer */
+DELETE FROM `gameobject_loot_template` WHERE `Entry`=26974 AND `Item`=54811;
+INSERT INTO `gameobject_loot_template` (`Entry`, `Item`, `Reference`, `Chance`, `QuestRequired`, `LootMode`, `GroupId`, `MinCount`, `MaxCount`, `Comment`) VALUES (26974, 54811, 0, 1, 0, 1, 0, 1, 1, 'Gift of the Observer - Celestial Steed');

src/naxx40Scripts/boss_gluth_40.cpp

@@ -204,7 +204,7 @@ public:
                     {
                         if (zombie->IsAlive())
                         {
-                            int32 reduceHp = int32(zombie->GetMaxHealth() * 0.05f);
+                            uint32 reduceHp = uint32(zombie->GetMaxHealth() * 0.05f);
                             if (zombie->GetHealth() > reduceHp)
                                 zombie->SetHealth(reduceHp); // Reduce HP to 5%
                             zombie->SetWalk(true); // Set to walk

src/naxx40Scripts/instance_naxxramas.cpp

@@ -1363,7 +1363,7 @@ public:
         return new gobject_naxx40_teleAI(object);
     }
 
-    bool OnGossipHello(Player* player, GameObject* go) override
+    bool OnGossipHello(Player* player, GameObject* /*go*/) override
     {
         if ((!sIndividualProgression->requireNaxxStrath || player->GetQuestStatus(NAXX40_ENTRANCE_FLAG) == QUEST_STATUS_REWARDED) && isAttuned(player))
         {