nullptr exception

src/Playerbots.cpp

@@ -209,30 +209,16 @@ public:
 
     void OnPlayerGiveXP(Player* player, uint32& amount, Unit* /*victim*/, uint8 /*xpSource*/) override
     {
-        // early return
+        if (!player->GetSession()->IsBot())
-        if (sPlayerbotAIConfig->randomBotXPRate == 1.0 || !player)
+            return;
+        
+        if (!sRandomPlayerbotMgr->IsRandomBot(player))
             return;
 
-        // no XP multiplier, when player is no bot.
+        if (sPlayerbotAIConfig->randomBotXPRate != 1.0)
-        if (!player->GetSession()->IsBot() || !sRandomPlayerbotMgr->IsRandomBot(player))
-            return;
-
-        // no XP multiplier, when bot has group where leader is a real player.
-        if (Group* group = player->GetGroup())
         {
-            Player* leader = group->GetLeader();
+            amount = static_cast<uint32>(std::round(static_cast<float>(amount) * sPlayerbotAIConfig->randomBotXPRate));
-            if (leader && leader != player)
-            {
-                if (PlayerbotAI* leaderBotAI = GET_PLAYERBOT_AI(leader))
-                {
-                    if (leaderBotAI->HasRealPlayerMaster())
-                        return;
-                }
-            }
         }
-
-        // otherwise apply bot XP multiplier.
-        amount = static_cast<uint32>(std::round(static_cast<float>(amount) * sPlayerbotAIConfig->randomBotXPRate));
     }
 };
 

src/factory/PlayerbotFactory.cpp

@@ -164,15 +164,16 @@ void PlayerbotFactory::Init()
         {
             continue;
         }
+        
         ItemTemplate const* proto = sObjectMgr->GetItemTemplate(gemId);
+        if (proto) {
+            if (proto->ItemLevel < 60)
+                continue;
 
-        if (proto->ItemLevel < 60)
+            if (proto->Flags & ITEM_FLAG_UNIQUE_EQUIPPABLE)
-            continue;
+               continue;
-
-        if (proto->Flags & ITEM_FLAG_UNIQUE_EQUIPPABLE)
-        {
-            continue;
         }
+        
         if (sRandomItemMgr->IsTestItem(gemId))
             continue;
 
@@ -180,9 +181,11 @@ void PlayerbotFactory::Init()
         {
             continue;
         }
+        
         // LOG_INFO("playerbots", "Add {} to enchantment gems", gemId);
         enchantGemIdCache.push_back(gemId);
     }
+    
     LOG_INFO("playerbots", "Loading {} enchantment gems", enchantGemIdCache.size());
 }
 

src/strategy/actions/MoveToTravelTargetAction.cpp

@@ -18,7 +18,7 @@ bool MoveToTravelTargetAction::Execute(Event event)
     WorldLocation location = *target->getPosition();
 
     Group* group = bot->GetGroup();
-    if (group && !urand(0, 1) && bot == botAI->GetGroupMaster() && !bot->IsInCombat())
+    if (group && !urand(0, 1) && bot == botAI->GetGroupMaster())
     {
         for (GroupReference* ref = group->GetFirstMember(); ref; ref = ref->next())
         {