- rewrote BaseType::iterate() to be a generator and yield references (requires php 5.5)
- reduced usage of bandaid BaseType::reset()
- removed Util::getIdFieldName() which was even more of a bandaid
- discovered DBSimple::selectPage() and consequently removed $matchQuery as they are now obsoloete
Util:
- added trainerTemplate lists for future use with trainers and trained spells
misc. forgotten and/or broken stuff here and there
* moved static item-scaling data to datasets
* Tooltips should now be able to display secondary tooltips (maps) and handle "known" spells (parsing those would be the next step)
tabs to spaces .. a lot
- consequentially prepended $WH to those functions (since i do have issues with regEx, some errors may occur)
* simplified including required JS and CSS files per page
* replaced old Menu-class with (almost) current version. Since it relies heavily on jQuery it is also loaded.
- fixed caching, by escaping control chars
- rough support for shortened urls .. kinda
- achievements shows icons for required items again; also can get name for quest
I'm not overly happy with passing the templateObject to each typeObject, but it works .. for now.
Effectively this should reduce db-lookups as each type should be looked up only twice at max (once for relevant data on the page and maybe again to get related jsGlobals for the template)
also removed BaseType::addRewardsToJscript() get it with BaseType::addGlobalsToJscript() and the appropriate addMask
* added ListviewHelper::getSetFields() wich is more appropriate in some cases (like reagents for spells should be shown even if they are all the same)
* load bricks as needed, removed the if-blocks (maybe add the filename to every TypeClass..?)
- removed excess escapes (htmlspecialchars really needed?)
* urlencode icons for all powered tooltips (some contain obscure symbols)
Spell:
- added relatedTabs "criteria of" and "contains" (the later should be reworked with generic loot access)
* implemented first draft of conditions in listview as extraCol; condition: {type, typeId, status}; currently only inpmplemented in the item-brick
* obligatory oneliners all over the place fixing stuff that boggles the mind
- add hardcoded Totem-DisplayIds
Spell:
- fixed amount/damage not being displayed, when spell had createItemId set but no effect to create it
- respect interactivity for constructs in tooltip
- parse playerLevel as textVar, if the constuct cant be evaled
- fixed functionality to change level on tooltips granting ratings
- added related tabs: 'modified by', 'modifies', 'used by item', 'used by itemset', 'see also'
* some minor cleansing in js-tooltip code
- improved handling of rewards
Spell:
- moved calcuation of effectValue to separate function, use realPointsPerLevel
- eval: applied proper format, fixed evalable string when facing multiple signs in a row
- display modelviewer for summons
Titles:
- looks like titles behave differently when using "faction" or "side"
Achievement:
- implemented rewards (which i have forgotten for almost 2 years)
* reworked pet-setup
* typos and forgotten changes, that broke code here and there
- plus food and talents, minus zones (those are just madning)
- also addes some bc/classic information on pet scaling
* mucked about the modelviewer, always uses high quality version .. should muck about some more to add animation-info and remove the java-option
* fixed some minor issues in spell maxaffectedtaregs in spell is displayed properly and erronous adding all classes/races to globals if none where selected
* created own table for creatures which unifies creature_template, locales_creature, creature_template_addon and some creatureDisplayInfo.dbc information
* more work against listviews and general structure in global.js .. should probably split this file by class and reassemble it for use
- while the code and strings are there, no rules have been set concerning availability
User:
- HTTP_ACCEPT_LANGUAGE may not be set.
Compare:
- removed some relic code, that, once uppon a time, was used to link virtual item sets with real item sets or something..
Titles:
- fixed a few forgotten changes
Lang:
- hide DND-entries for locks
BaseType:
- improved getField to automaticaly cast numerics to float
- improved __construct to check for numeric instead of int
- preparing tooltips (locks to Util & localization)
quests & npcs:
- implemented tooltips
spells:
- fixed tooltip-header
- stat gain inclued periodic healing auras (item: 17743 for example) and spellHeal no longer applies spellPower
achievements:
- path is less prone to errors
events:
- disabled tab as it was causing js-errors
obligatory cleaning up everywhere
* updated Summary.js (Item Comparison)
- can now manage custom weightscales, when logged in
- can now apply weightscales to rank search results
- CAN NOT yet search for items with a certain scale alone, as i haven't figured out yet how to design the database for that
* sorted and commented basic.css
* some missing imagery
* some cleanup
(my todoStack just got less inhuman in size)
Spells:
- improved tooltips to use a less table-dependant layout
- defined the missing fulltext-variables
- buff or tooltip are only reandered for the current spell
- reduced redundancy in buff / tooltip-code
some ToDos:
- no tabs on the detail-page implemented yet (used-by, affected-by, ect)
- localization for frFR, esES and ruRu is .. lacking and will probably be commited with the point above)
- a full search runs for almost 2sec and i haven't implemented every type yet >.< .. spells are too greedy
- in some cases $d must supply a time unit, in most cases it does not .. why..?
- sources can be improved .. anything related to items is still missing
- added some more lasses for (for now) static use
Achievements:
- moved setup to separate file (not included yet (and shouldn't have been))
- unified use of the infobox.tpl
Items:
- Tooltip-layout changes, when used as standalone or incorporated in other tooltips. This can now be considered.
Util:
- added utf8-safe Util::ucFirst()
- added Lang::getRequiredItems() for use with spell - equippedItem[Sub]Class
Templates:
- minor wording fix (link -> links)
Markup:
- [class=X], [race=X], [money=X] added (i really shouldn't have done this)
- [color=X] now also accepts r1 - r4 as parameter
obligatory minor stuff here and there
- dropped property "names" and changed getField to return localized Fields if specified. Dropped stupid getNameFieldName() in the process as it was now obsolete.
- made property "matches" private. Access through getMatches() that will execute the query _only_ when needed (which is basically always anyway (so much for optimization))
SpellList: parsing
- ""fixed"" behavior of the amount-switch $l when used on russian text. It has 3 options instead of 2, no idea what the last one is for though
- fixed extra leading whitespace occuring when parsing formulas
Lang:
- removed offset from getMagicShools(), apparently it is unneeded :o
Util:
- changed the output of formatTime() in the long version to be more correct in layout
- initialized values in parseTime() to prevent empty strings returned by formatTime()
- added asBin() and asHex() - helper to improve display of bitmasks (Spells are coming!)
- update Spell-Effects/Auras and added misc strings to display different MiscValue-content
Filter:
- removed escapes from $_POST-handler. If the input is erronous it should be corrected/ignored/noted by the $_GET-handler
Smarty:
- added optinal parameter to saveCache(), loadCache() to better handle filter variables
Search:
- changed $maxResults to 10 for OpenSearches in an effort to lower execution time and appied limits to all queries
- changed result calculation for OpenSearch. It should now stick to it's limit of 10 results for the list
- simplified WorldEvent search
global.js:
- backported function to parse title-tag of dfn-elements into mouseover-tooltips
- shortened document.getElementByTagName(x) calls to gE(document, x)
- make offset optional, when converting list to mask
Items:
- fixed display of inventory type for robes and ranged weapons
Spells:
- parsing: $charLevel and $interactive are now properties of spell.
- parsing: fixed durations, passing the time-unit seperately to allow for evaluation of the actual value
- parsing: fixed gender-specific formating [ >male/female< to <male/female>]
- parsing: usage of is_numeric() instead of (float) as 0 is a fucking valid numeric (caused some formulas to not be evaluated *grrr*)
- parsing: lastValue-references now skip to the next previous \d instead of being stopped by random \w (like time units)
- implemented forgotten display of runes for spellCost
- fixed castTimes for most hunter shots (they are -1000 for some reason)
- fixed display of required stances (sometimes they are not actually required but show, when you are _allowed_ to use a spell in certain forms)
- improved formating of tooltips-js (no visual change)
ListViews:
- pass '_truncated' separately. there are nough cases in which 'note' gets send without truncated results
misc changes here and there
this allows for better flag matching i.e. [(flags & 0x4) = 0]
furthermore it is now possible to group conditions to a subset with a different link
* hasDiffCategories() -> hasDiffFields(array $fields)
now returns a bitmask of the array keys what field does diff
spell:
- removed weired break from tooltips
- fixed time units being omitted by intval and subsequent cast to int
achievement:
- casting id to int to avoid string-comparison in mysql (sped up load a lot)
localization:
- fixed malformed file
infobox:
- show video-options only when logged in
filter:
- allow underscores in search (icon search)
search:
- really fixed prepended quality for items
a few things to consider:
- the virtual Itemset-Ids will not be the same as wowheads. Which dosn't really matter imho..
- the Arena-Sets all have their base names. I've to admit, i'm not too fond of the idea to collect 40 prefix-strings and attach them manually. But i see no other option.
- availability for players is not supported. I dread the thought of crawling through vendor and loot-tables for every .. single .. item!
- what which index does needs to be implemented in the implementation
- differences to wowhead
* strings in criteria are more lenient and will also work with partial matches
* the ? and * wildcards are supported
simple listview-pages now use one shared template (instead of having the same file multiple times)
some bug fixing here and there
- achievement: faction is no longer out of range (need to reparse the faction :/)
- item: quality is prepended to the name again and wont be left out in case of heirlooms (is 0)
- general: forgot to change some error()-calls in index
- and some more wich i forgot..
